Unable to select vertex paint face mask faces while retopology overlay is active #107768

New Issue

Open

opened 2023-05-09 02:21:19 +02:00 by dgkf · 9 comments

dgkf commented

2023-05-09 02:21:19 +02:00

System Information
Operating system: Ubuntu 23.04
Graphics card: AMD Radeon RX 570

Blender Version
Broken: main (e151425c5c1085d7be5f8bb2ad694a869bc16dc7)

Short description of error
If the new retopology overlay is active in edit mode, vertex paint faces can't be selected

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

With default cube in Edit mode, enable the Retopology overlay
Switch to Vertex Paint mode
Enable face selection masking
Try to select a face

A small video is attached, showing first successful selection of a vertex paint face mask while the retopology overlay is inactive, then the inability to select vertex paint face mask faces after it's activated.

**System Information** Operating system: Ubuntu 23.04 Graphics card: AMD Radeon RX 570 **Blender Version** Broken: `main` (`e151425c5c1085d7be5f8bb2ad694a869bc16dc7`) **Short description of error** If the new retopology overlay is active in edit mode, vertex paint faces can't be selected **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). 1. With default cube in _Edit_ mode, enable the Retopology overlay 2. Switch to _Vertex Paint_ mode 3. Enable face selection masking 4. Try to select a face A small video is attached, showing first successful selection of a vertex paint face mask while the retopology overlay is inactive, then the inability to select vertex paint face mask faces after it's activated.

retopo-vertex-paint.webm

735 KiB

dgkf added the

labels 2023-05-09 02:21:20 +02:00

YimingWu commented

2023-05-09 06:28:20 +02:00

Member

Can confirm. Assuming this never worked since the retopology overlay is a new feature. Set high for recentness.

Can confirm. Assuming this never worked since the retopology overlay is a new feature. Set high for recentness.

YimingWu added

EEVEE & Viewport

and removed

labels 2023-05-09 06:28:49 +02:00

Jeroen Bakker commented

2023-05-09 16:30:38 +02:00

Member

@JulienKaspar Does it make sense to have retopoly overlay enabled for vertex paint mode?
I can imagine we only draw the retopology overlay in edit mode where it makes sense.

Ps I don't consider this a high priority issue as it users can still work with vertex paint by disabling the overlay. Note that this should be fixed for the next release

@JulienKaspar Does it make sense to have retopoly overlay enabled for vertex paint mode? I can imagine we only draw the retopology overlay in edit mode where it makes sense. Ps I don't consider this a high priority issue as it users can still work with vertex paint by disabling the overlay. Note that this should be fixed for the next release

Jeroen Bakker added this to the 3.6 LTS milestone 2023-05-09 16:30:44 +02:00

Jeroen Bakker added

and removed

labels 2023-05-09 16:31:07 +02:00

Julien Kaspar commented

2023-05-09 16:37:12 +02:00

Member

The overlay should only be for Edit Mode yes.

The overlay should only be for Edit Mode yes.

YimingWu commented

2023-05-09 17:03:02 +02:00

Member

I got this far and it apparently still didn't work 😅

edit: see the patch in the next comment

I got this far and it apparently still didn't work 😅 edit: see the patch in the next comment

YimingWu commented

2023-05-09 17:22:04 +02:00

Member

Well this is working for selection but apparently I broke some more display stuff than just get it to work. 😅

I suggest renaming DRW_object_is_in_edit_mode to something like DRW_object_should_not_occlude_selection and have another separate function for the display portion of that similar call, so we don't use them interchangeably leading to confusion.

Well this is working for selection but apparently I broke some more display stuff than just get it to work. 😅 I suggest renaming `DRW_object_is_in_edit_mode` to something like `DRW_object_should_not_occlude_selection` and have another separate function for the display portion of that similar call, so we don't use them interchangeably leading to confusion.

draw_select

9.4 KiB

YimingWu referenced a pull request that will close this issue

2023-05-11 09:02:50 +02:00

Fix #107768: vertex paint selection with retopology overlay #107833

YimingWu commented

2023-05-25 08:49:04 +02:00

Member

Entering vertex paint mode now gives me an Attempt to free a NULL pointer error, somewhere around ss->pmap = blender::bke::mesh::build_vert_to_poly_map

I don't think it's very relevant to this specific issue tho

Entering vertex paint mode now gives me an `Attempt to free a NULL pointer` error, somewhere around `ss->pmap = blender::bke::mesh::build_vert_to_poly_map` I don't think it's very relevant to this specific issue tho

YimingWu referenced this issue

2023-06-19 05:37:44 +02:00

Eyedropper picker Afected by retopology overlay #109115

YimingWu referenced this issue

2023-06-30 06:42:46 +02:00

Viewport Z-Bias & retopology overlay related issues #109545

YimingWu commented

2023-07-16 10:51:41 +02:00

Member

Still broken on current main.

Still broken on current main.

Julien Kaspar commented

2023-07-17 10:33:29 +02:00

Member

@Jeroen-Bakker To make sure this issue is fixed for the next release, shouldn't it be set to high priority?

@Jeroen-Bakker To make sure this issue is fixed for the next release, shouldn't it be set to high priority?

YimingWu commented

2023-07-17 11:03:45 +02:00

Member

Ps I don't consider this a high priority issue as it users can still work with vertex paint by disabling the overlay. Note that this should be fixed for the next release

The problem I see for now is that the user might be switching from edit mode to vertex paint/weight paint and the overlay switch could still be on and users won't know the difference either, leading to confusion. So I think it can be set as high priority?

> Ps I don't consider this a high priority issue as it users can still work with vertex paint by disabling the overlay. Note that this should be fixed for the next release The problem I see for now is that the user might be switching from edit mode to vertex paint/weight paint and the overlay switch could still be on and users won't know the difference either, leading to confusion. So I think it can be set as high priority?

Guillermo Venegas referenced a pull request that will close this issue

2023-07-20 18:17:07 +02:00

Fix #107768: Unable to select vertex paint face mask faces while retopology overlay is active #110311

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107768

No description provided.