Blender Foundation: Blender 2.x BF release: Detail: 32703 elbeem's isSimworldOk() will never return FALSE.

Log In
New Account

[#32703] elbeem's isSimworldOk() will never return FALSE.

Date:
2012-09-30 08:46 Priority:
3

State:
Closed

Submitted by:
Campbell Barton (campbellbarton) Assigned to:
Daniel Genrich (genscher)

Category:
None Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
elbeem's isSimworldOk() will never return FALSE.

Detailed description

intern/elbeem/intern/utilities.cpp

int isSimworldOk(void) {
return (getElbeemState>=0);
}

should be ....
return (getElbeemState() >= 0);

Since this is so close to release, reporting and assigning to Daniel.

Followup

Message

Date: 2012-10-09 15:09
Sender: Daniel Genrich
Hey,

very nice catch. That function could also mean "gElbeemState" instead of "getElbeemState()" but nevertheless it's a bug and it could be responsable for several endless loops I got reported.

Thanks for pointing this out!

Fixed in svn.

Attached Files:

No Files Currently Attached

Changes:

Field	Old Value	Date	By

status_id	Open	2012-10-09 15:09	genscher
close_date	None	2012-10-09 15:09	genscher
Status	New	2012-10-09 15:09	genscher