Blender Foundation: Blender 2.x BF release: Detail: 32931 Crop node resets values to 0

Log In
New Account

[#32931] Crop node resets values to 0

Date:
2012-10-20 20:45 Priority:
3

State:
Closed

Submitted by:
Daniel Toplak (dato) Assigned to:
Jeroen Bakker (jbakker)

Category:
Compositor Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
Crop node resets values to 0

Detailed description

I have a crop node in a group which should crop out the middle 512*512 pixels from a 1536*1536 image.
I use Left= 512, Right=1024, Up=512, Down=1024.

I have viewer node in my group which display the correct croped image in the backdrop, but when I close my group the variables of the crop node are reseted to 0 and in the blender consol I see the following error:
OpenColorIO Error: PackedImageDesc Error: Image dimensions must be positive for both x,y. '1x0' is not allowed.

I have tried with an easy setup but there it work.

Blender Version 2.64a Windows 64.

Followup

Message

Date: 2012-10-20 21:58
Sender: Markus Kasten
I can confirm this happens when the output of a group node is detached in r51430. I'll add a blend file that proofs the behaviour.

Date: 2012-10-20 22:03
Sender: Markus Kasten
Here's the file. (Didn't know I have to add it to the same message.)

Date: 2012-10-21 17:24
Sender: Ton Roosendaal
Patch looks ok, but let's ask Jeroen first.

Date: 2012-10-21 17:38
Sender: Markus Kasten
I added a patch, which solves the problem for me.

I also found, when you don't have an output connected on the crop node in a group, it always resets it's values to 0 (I think I fixed it too).

Date: 2012-10-21 20:19
Sender: Daniel Toplak
Tested the patch, it works fine, thanks.

One thing: it will be nice if the left, right, up, down values can be controlled by a slot.

Date: 2012-10-21 21:01
Sender: Jeroen Bakker
Patch committed in revision 51483.
Thanks for the fix Markus and thanks for the report Daniel!

the fix was related that the old compositor decides the images based on its inputs, but this is only validated in tiles when it is connected. The old implementation has been copied over, but not adjusted for the new behavior. The fix does this.

IMO the whole node needs to be re-designed :)

Attached Files:

Name	Date	Download

Crop Node.blend	2012-10-20 22:03	Download
crop_node_zero.patch	2012-10-21 17:38	Download

Changes:

Field	Old Value	Date	By

status_id	Open	2012-10-21 21:01	jbakker
close_date	None	2012-10-21 21:01	jbakker
Status	Investigate	2012-10-21 21:01	jbakker
File Added	22472: crop_node_zero.patch	2012-10-21 17:38	markus111
assigned_to	none	2012-10-21 17:24	ton
Status	New	2012-10-21 17:24	ton
File Added	22458: Crop Node.blend	2012-10-20 22:04	markus111