Only search projects.blender.org
 Log In
New Account
Home My Page Projects Blender 2.x BF release
Summary Activity Tracker SCM Files

Blender 2.6 Bug Tracker: Browse

[#19481] Changing properties to redo knife, loopcut, and other tools does not work

Date:
2009-09-27 19:42		 Priority:
3
State:
Closed
Submitted by:
Roland Hess (harkyman) 		Assigned to:
Ton Roosendaal (ton)
Category:
Tools		 Status:
Fixed / Closed
Relates to:
Duplicates:
Patches:
 
Summary:
Changing properties to redo knife, loopcut, and other tools does not work
Detailed description
The tweak panel below the shelf shows the proper controls, but does nothing. Using the "Tweak..." button popup, however, works fine.

Followup

Message
  • Date: 2009-09-27 23:35
  • Sender: Joshua Leung
  • This bug is not specific to the knife tool. Rather, any operator which requires a region3dview to operate will face similar problems (i.e. Grease Pencil drawing also has this problem). The main problem here is that when the mouse is operating some buttons in the tweak panel, the active region is the tweak region instead of the one of the 3d-views. Hence, the operators can either refuse to work, or if they don't account for this condition will crash when window_to_3d() or equivalent function tries to get some data from ar->regiondata and fails.
  • Date: 2010-09-23 09:54
  • Sender: Caleb
  • Will this be fixed soon? This bug has been open for a year now.
  • Date: 2010-09-23 10:36
  • Sender: Andrew Davies
  • Also it might be worth noting that hitting enter after a loopcut is created does not apply the loopcut.
    Is this related?
  • Date: 2010-11-09 11:33
  • Sender: Ton Roosendaal
  • OK; here's my take on this.

    The loopcut code hasn't been implemented allowing redos, since it fully depends on a modal handling (selecting edges first while moving mouse). Without this manual input, the operator doesn't work. Has nothing to do with RegionView3d input, that could work fine (since operator redo moves context to main window default).

    Designing this properly is somewhat tricky, but it definitely has to be done 'state' based, creating a selection (group) or otherwise tagged edge and operating on it. The invoke() and modal() then can create the selection, store it in mesh data, and then call an exec(). That makes redo work.

    Or better, Operators should not do selecting combined with exects, actually. The modal input method could be an operator itself, and used as macro together with the loopcutting operator.

    To me this seems to be a very generic topic for other modal-selection tools as well. Need to find the people who worked on this first to discuss it.
  • Date: 2010-11-09 12:35
  • Sender: Ton Roosendaal
  • Testing bug tracker, it doesn't send mails?
  • Date: 2010-11-11 15:19
  • Sender: Ton Roosendaal
  • I've noted the topic in our todo wiki, and when Joe doesn't have time tackle myself within next weeks.
  • Date: 2011-06-23 15:39
  • Sender: Andrew Davies
  • Any update on this?
    It still doesn't seem to work in 2.58

    Thanks!
 

Attached Files:

No Files Currently Attached

Changes:

Field Old Value Date By
close_date2010-11-11 15:192010-11-11 15:19ton
status_idOpen2010-11-11 15:19ton
ResolutionInvestigate2010-01-25 23:53blendix
summaryKnife tweak works from "Tweak..." button on tool shelf, but not Tweak Panel below shelf2010-01-25 23:53blendix
assigned_tonone2010-01-25 23:53blendix
ResolutionNone2010-01-11 02:05broken
summaryKnife tweak works from "Tweak..." button on tool shelf, but not Tweak Panel below shelf2010-01-11 02:05broken
summaryKnife tweak works from "Tweak..." button on tool shelf, but not Tweak Panel below shelf2009-09-27 23:35aligorith