Blender Foundation: Blender 2.x BF release: Detail: 23152 Area light with noshadow is affected by rayshadow sampling setup (Kino Bug Reporting Sprint)

Log In
New Account

[#23152] Area light with noshadow is affected by rayshadow sampling setup (Kino Bug Reporting Sprint)

Date:
2010-08-02 16:27 Priority:
3

State:
Closed

Submitted by:
Luca Bonavita (mindrones) Assigned to:
Brecht Van Lommel (blendix)

Category:
Rendering Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
Area light with noshadow is affected by rayshadow sampling setup (Kino Bug Reporting Sprint)

Detailed description

In the attached file we have an area light bigger then the object:
- render
- left face renders black
- set rayshadows
- set sample > 1
- set noshadow again
- render
- side face is gray <--- !

- set rayshadows
- set sample to 1
- set noshadow again
- render
- side face is back

Shoudn't NOSHADOW be unaffected by rayshadows setup?

Assigning brecht as per Campbell suggestion.

----------------------------------------------------------

Reported in a Bug Reporting Sprint
number 12 @ http://www.kino3d.com/forum/viewtopic.php?p=90955#90955

Reported by: Gillian
Confirmed by: Mindrones (+ Ideasman42 in IRC)

Gillian
----------------------------------------------------------

---blender ---
* blender version: 2.53
* build: official

---platform ---
* operating system: Windows
* bitness: 32

--- hardware ---
* RAM: 4 GB
* Graphic card: nvidia
* Motherboard: intel quad core

Mindrones
----------------------------------------------------------

---blender ---
* blender version: 2.53.1 rev.30982
* build: debug/profiling build with cmake

---platform ---
* operating system: Linux Mandriva 2010.0
* bitness: 32

--- hardware ---
* RAM: 2GB
* Graphic card: Intel
* Motherboard: -

Followup

Message

Date: 2010-08-04 11:03
Sender: Brecht Van Lommel
This is actually a UI problem, area lights also use the samples for sampling the form factor, but they are in the shadow panel, probably for area lights that button should be moved.

Date: 2010-08-05 20:05
Sender: Luca Bonavita
I've done done a patch to fix this, I just need some time to conform my changes to other lamp types as well, and I'll post the patch in the tracker.

Date: 2010-08-06 14:25
Sender: Luca Bonavita
I've made a patch for this here
https://projects.blender.org/tracker/index.php?group_id=9&atid=127

This moves the samples field so that it is visible in area lamps when noshadow is clicked, and indeed fixes the problem.

While I was at the I've added the condition if wide_ui where needed (not everywhere, if this is ok I can do) and modified the sampling buttons so that only those depending on the sampling method are below the sampling method selector, while the general ones come first so it's immediate to see them as linked.

Formatted so that options for constant jitter appear below that button, so it's faster to setup. Same for QMC which has the threshold just below, and not wide as the column, more communicative.

Date: 2010-08-06 20:54
Sender: Luca Bonavita
The patch is now in trunk, closing this bug.

Date: 2010-11-18 10:33
Sender: Luca Bonavita
changed to "resolution: fixed"

Attached Files:

Name	Date	Download

12-cube_and_area.blend	2010-08-02 16:27	Download

Changes:

Field	Old Value	Date	By

Resolution	None	2010-11-18 10:33	mindrones
close_date	2010-11-18 10:33	2010-11-18 10:33	mindrones
close_date	2010-08-06 20:54	2010-08-06 20:54	mindrones
status_id	Open	2010-08-06 20:54	mindrones
File Added	11999: 12-cube_and_area.blend	2010-08-02 16:27	mindrones