Blender Foundation: Blender 2.x BF release: Detail: 24163 Unable to animate INSIDE a group node in the compositor

Log In
New Account

[#24163] Unable to animate INSIDE a group node in the compositor

Date:
2010-10-06 10:06 Priority:
3

State:
Closed

Submitted by:
ben u (benu) Assigned to:
Joshua Leung (aligorith)

Category:
Animation system Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
Unable to animate INSIDE a group node in the compositor

Detailed description

OS X 10.6.2; r32297 (blender build, from graphicall.org)

I can animate the Offset value in the "Map Value" node, but when I put it in a group, the values no longer change over time.

The first blend "1_withoutGroup_animatedFine.blend" is my first setup. Render the 24-frame animation and view the result.

For my second group "2_withGroup_noAnimation.blend" I took the first blend and grouped the two [animated] Map Value nodes and the Mix node. Render the animation: now the animated values aren't changing.

Nor do the Offset values appear on the group node itself (as some, but not all, of the grouped values appear on the node itself), so the only option is to animate INSIDE the group node, but the values won't respond properly.

Interestingly, if I then UNgroup the buggy, non-animating node, the animation works again.

I appreciate your help!

Followup

Message

Date: 2010-10-06 11:56
Sender: ronan ducluzeau
ubuntu 10.04, 64 bits , rev32339

Related to 23870.
IMHO, problem is more obvious in this example with animated offset.

Date: 2010-11-03 14:09
Sender: Janne Karhu
Confirmed & assigned to self for investigation.

Date: 2010-11-03 15:27
Sender: Janne Karhu
Hmm, the problem is that there isn't a proper way to create an rna path to a value of a node that's in a group. You can animate the group inputs though, which I find a bit confusing, since you'd expect the inputs to mirror the actual nodes in the group fully. However even if this connection is made it doesn't cover for animating values inside the group that don't create an input for the group.

I don't know enough about rna and how the whole system with group nodes is intended to work to try and fix this, so assigning this to Campbell.

Date: 2010-11-17 19:29
Sender: Ton Roosendaal
This is more for Joshua to give feedback on.

Once you group nodes, it makes it an ID block, and moves it away in the main database.
The animation curves then should get a new root, i guess... not sure either how this was foreseen to work :)

Date: 2010-11-30 10:19
Sender: Joshua Leung
Since F-Curves for the nodes are stored at nodetree level, in order to allow this splitting to work, we're going to have to isolate relevant F-Curves (and/or drivers in future) so that this sort of thing will still work.

At the time of setting up nodetree support, I was not aware of some of these "finer points" of the nodes system, which really aren't that obvious. In that regard, I guess this is something that is "working like it was intended to", though probably it would be nice to do this someday (keeping in mind that 2.5 is the first version that we can even animate nodes, I think one or two "known issues" still might not hurt that much ;)

Date: 2010-12-07 11:32
Sender: Joshua Leung
While trying to set up a test case from scratch in current trunk, I noticed another bug here. :(

It seems that trying to keyframe a node within group within the Node Editor also fails, since the context functions are only picking up the context for the Node Editor, but not within the group node. That is, the ID-block that it's trying to insert a keyframe in is the nodetree referencing the group, vs the group's ID.

Will fix this error first!

Date: 2010-12-29 12:52
Sender: Joshua Leung
Main issue in this report is now fixed in svn.

There are still a few other todos, as noted in the commitlog which I'll fix shortly too, so I guess this report can be closed now :)

Attached Files:

Name	Date	Download

1_withoutGroup_animatesFine.blend	2010-10-06 10:06	Download
2_withGroup_noAnimation.blend	2010-10-06 10:06	Download

Changes:

Field	Old Value	Date	By

status_id	Open	2010-12-29 12:52	aligorith
close_date	None	2010-12-29 12:52	aligorith
Status	Ready	2010-12-29 12:52	aligorith
assigned_to	campbellbarton	2010-11-17 19:29	ton
Resolution	Investigate	2010-11-03 15:27	jhk
assigned_to	jhk	2010-11-03 15:27	jhk
Resolution	None	2010-11-03 14:09	jhk
assigned_to	none	2010-11-03 14:09	jhk
File Added	13009: 2_withGroup_noAnimation.blend	2010-10-06 10:06	benu
File Added	13008: 1_withoutGroup_animatesFine.blend	2010-10-06 10:06	benu