Log In
New Account
Home My Page Projects Blender 2.x BF release
Summary Activity Tracker SCM Files

Blender 2.6 Bug Tracker: Browse

[#24726] Second file load crashes

Date:
2010-11-15 11:02
Priority:
3
State:
Closed
Submitted by:
Janne Karhu (jhk)
Assigned to:
Ton Roosendaal (ton)
Category:
Interface
Status:
Fixed / Closed
Relates to:
Duplicates:
Patches:
 
Summary:
Second file load crashes
Detailed description
Loading a blend file or reloading the same file after working on some a blend file crashes on wm_handler_fileselect_call(..) in wm_event_system.c on line 1295 in the check for "if(wm->op_undo_depth == 0)".

It seems that the wm can get changed by the operator somehow, so the wm pointer can be corrupt after the operator exec. In other cases around the line a check for (CTX_wm_manager(C) == wm) is used before accessing anything through the old wm pointer, so I guess this is already a known issue, but just a missing check on line 1295?

Mostly this happens on the second load, but other times a couple of loads are needed. This happens with either loading through a hotkey or from the menu entry.

WinXP 32bit on any recent revision

Followup

Message
  • Date: 2010-11-15 17:26
  • Sender: Ton Roosendaal
  • Can't redo here... but your observation seems correct.
    Still very fuzzy here. After a filesel exec context can change completely, so it should not pass on any variable then.

    I will commit the proposed fix with warnings in code for cleanup later.
 

Attached Files:

No Files Currently Attached

Changes:

Field Old Value Date By
ResolutionNew2010-11-15 17:26ton
close_date2010-11-15 17:262010-11-15 17:26ton
status_idOpen2010-11-15 17:26ton