Blender Foundation: Blender 2.x BF release: Detail: 25365 template_ID default unlink method doesn't work for Object types

Log In
New Account

[#25365] template_ID default unlink method doesn't work for Object types

Date:
2010-12-23 22:30 Priority:
3

State:
Closed

Submitted by:
Dan Eicher (dna) Assigned to:
Ton Roosendaal (ton)

Category:
Interface Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
template_ID default unlink method doesn't work for Object types

Detailed description

AFAICT clicking the 'X' button on a template_ID box just unlinks the object (or object->data) from space.pin_id and not from the scene or object as one would expect.

Shift+click drops the user count but that's it, no unlinking.

The one in DATA_PT_context_curve is just plain broken... space.pin_id isn't getting set or somesuch.

Attached is a patch that adds an unlink="None" method so the 'X' box isn't displayed in the broken cases -- or if someone wanted to use one of those in their own panel and doesn't want to show the 'X' button (since it can't currently be turned off).

Also in the patch are some panel cleanups (remove unneeded splits) and a fix for the custom bone shape user count bug.

Followup

Message

Date: 2010-12-24 11:16
Sender: Ton Roosendaal
The 'x' unlinks from its parent data, it never deletes nor unlinks from a scene and 'space pin' is just internal ui data. There is no 'x' option for objects itself even.
The "shift click" is a hack at best... and the tooltip is even wrong. Can fix that.

The object->data level shouldn't get an 'x' object, that's not supported indeed.

The custom bone fix was already in svn, using newlibadr_us() which links with user counting.

Attached Files:

Name	Date	Download

template_ID.diff	2010-12-23 22:30	Download

Changes:

Field	Old Value	Date	By

status_id	Open	2010-12-24 11:16	ton
close_date	None	2010-12-24 11:16	ton
assigned_to	none	2010-12-24 11:16	ton
Status	New	2010-12-24 11:16	ton
File Added	14235: template_ID.diff	2010-12-23 22:30	dna