Blender Foundation: Blender 2.x BF release: Detail: 25375 Vertical numbers in F-Curve Editor out-of-alignment with grid

Log In
New Account

[#25375] Vertical numbers in F-Curve Editor out-of-alignment with grid

Date:
2010-12-24 19:57 Priority:
3

State:
Closed

Submitted by:
ben u (benu) Assigned to:
Sergey Sharybin (nazgul)

Category:
Interface Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
Vertical numbers in F-Curve Editor out-of-alignment with grid

Detailed description

The screenshot and attached blend made on OS X 10.6.2, r33584 (tkroo build from graphicall), but it has also been confirmed on Ubuntu 10.04.

See attached image. A keyframe with a value of, say, -10.0 will fall exactly on the default grid of the F-Curve Editor. However, the *number* "-10.0" isn't aligned with the graph. It seems that the spacing between numbers doesn't correlate exactly with the spacing of the grid.

This only seems to happen with vertical numbers, and is most evident in the negative ones.

The attached blend file should open directly to where I took the screenshot.

A brief discussion of this is at http://blenderartists.org/forum/showthread.php?t=205303&p=1760808

Followup

Message

Date: 2010-12-25 23:55
Sender: Sergey Sharybin
Could be easily reproduced with just opening attached, but was unable to to create such big offset of axis values "from scratch". Maybe something it this area was already fixed since version, in which file was created?

But anyway, there is annoying offset which seems to be caused by scrollbars are drawn with offset from area boundaries, but grid is not or meaybe because of ignoring scrollbars size when drawing grid.

Date: 2010-12-26 08:26
Sender: Alexander Kuznetsov
In view2d.c line 1700+
V2D_SCROLL_HEIGHT is seems to be unnecessary (see horizontal code)
so this works better,
fac= (vert.ymin /*+ V2D_SCROLL_HEIGHT*/) + fac*(vert.ymax - vert.ymin /*- V2D_SCROLL_HEIGHT*/);
...
dfac= dfac * (vert.ymax - vert.ymin /*- V2D_SCROLL_HEIGHT*/);

I will look at this further

Date: 2010-12-26 11:35
Sender: Sergey Sharybin
Fixed in svn rev33890. Thanks for report and thanks Alex for comment!

Attached Files:

Name	Date	Download

measurements.blend	2010-12-24 19:57	Download
measurements.png	2010-12-24 19:57	Download

Changes:

Field	Old Value	Date	By

status_id	Open	2010-12-26 11:35	nazgul
close_date	None	2010-12-26 11:35	nazgul
assigned_to	none	2010-12-26 11:35	nazgul
Status	New	2010-12-26 11:35	nazgul
File Added	14245: measurements.png	2010-12-24 19:57	benu
File Added	14246: measurements.blend	2010-12-24 19:57	benu