Blender Foundation: Blender 2.x BF release: Detail: 25435 old bump mapping + mip map breaks on toggling

Log In
New Account

[#25435] old bump mapping + mip map breaks on toggling

Date:
2010-12-31 14:13 Priority:
3

State:
Closed

Submitted by:
M.G. Kishalmi (lmg) Assigned to:
Brecht Van Lommel (blendix)

Category:
Rendering Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
old bump mapping + mip map breaks on toggling

Detailed description

when turning off mipmapping in the texture properties
turning it back on has no effect.
found with old-bump-mapping turned on.

see attached .blend

r33965 @ linux64

Followup

Message

Date: 2010-12-31 14:59
Sender: M.G. Kishalmi
rna_texture.c:329

if(tex->imaflag & TEX_MIPMAP)
tex->texfilter = TXF_EWA;

it's switching the filter type to EWA when turning it back on again. that's causing the trouble.
why is it this happening?

might be a leftover from blendix r27493 removing SAT texfilter.

Date: 2010-12-31 15:34
Sender: Ton Roosendaal
Brecht: the rna code enforces EWA as a default, is that really needed?
And: happy 2011 :)

Date: 2011-01-02 11:52
Sender: Brecht Van Lommel
Fix in svn, thanks for the report / investigation.

Attached Files:

Name	Date	Download

bug_oldbump_mipmap.blend	2010-12-31 14:13	Download

Changes:

Field	Old Value	Date	By

status_id	Open	2011-01-02 11:52	blendix
close_date	None	2011-01-02 11:52	blendix
Status	Investigate	2011-01-02 11:52	blendix
assigned_to	none	2010-12-31 15:34	ton
Status	New	2010-12-31 15:34	ton
Category	None	2010-12-31 14:16	zanqdo
File Added	14322: bug_oldbump_mipmap.blend	2010-12-31 14:13	lmg