Only search projects.blender.org
 Log In
New Account
Home My Page Projects Blender 2.x BF release
Summary Activity Tracker SCM Files

Blender 2.6 Bug Tracker: Browse

[#25525] Duplicating (Split)Viewer node in Compositor crashes Blender *NEED CONFIRMATION*

Date:
2011-01-07 00:45		 Priority:
3
State:
Closed
Submitted by:
Damien Laflaquiere (yesmydear) 		Assigned to:
Ton Roosendaal (ton)
Category:
Compositor		 Status:
Fixed / Closed
Relates to:
Duplicates:
Patches:
 
Summary:
Duplicating (Split)Viewer node in Compositor crashes Blender *NEED CONFIRMATION*
Detailed description
Steps to reproduce:

1) start Blender
2) in the Node Editor, using Composite Nodes, add a Viewer node or SplitViewer node
3) try to duplicate the node

I'm using b2.56a r34135 (own compile) on Vista win32

- The same operation does not crash official b2.56a.
- Duplicating the Viewer node in Texture Nodes does not crash Blender

Followup

Message
  • Date: 2011-01-07 05:15
  • Sender: Campbell Barton
  • cant redo this crash r34137. linux, 64bit debug build.

    tried...
    - duplicating newly added node
    - duplicating with 2 inputs set (image showing)
    - duplicating node on its own
    - duplicating split viewer node with all other nodes selected.

    Can anyone else confirm?
  • Date: 2011-01-07 12:17
  • Sender: Davis Sorenson
  • Unable to confirm, Ubuntu 10.10 32bit r34150.
  • Date: 2011-01-07 12:58
  • Sender: Damien Laflaquiere
  • Also tested
    - after fresh compile (now r34154)
    - with cog's build on Graphicall (r34135)

    Blender crashes systematically when I try to duplicate an (Split)Viewer node in Composite Nodes.
  • Date: 2011-01-07 19:48
  • Sender: Xavier Raemy
  • Blender Official beta 2.56a x64 b34076
    Win 7 x64

    Confirmed in Windows 7 x64.
    Blender crashed after SHIFT-D on a Viewer node in the compositing node editor.
  • Date: 2011-01-07 20:42
  • Sender: Dario Senkic
  • Confirmed in Windows 7 x64, using official Blender 2.56a x64.

    Blender crashes when duplicating either the Viewer node, or the Split Viewer node.
  • Date: 2011-01-08 13:54
  • Sender: Ton Roosendaal
  • Tested in OSX with 2.56a release and current svn 34175, no crashers.

    Best is to attach a simple demo file with the setup, it might be related to something we don't redo correctly.
    I *really* have to insist reporters here to respect our bug reporting guidelines...
  • Date: 2011-01-08 17:48
  • Sender: Dario Senkic
  • I've attached a demo file. It's pretty much the default scene with nodes enabled and with an added Viewer node.
  • Date: 2011-01-08 18:20
  • Sender: Alexander Kuznetsov
  • Win7 x64 34176
    Node crashes on node_tree_from_ID (node_edit.c) because idtype=ID_IM (which doesn't exist in else if) and therefore *ntree is not assign
    The original call comes from node_duplicate_exec:
    /* to ensure redraws or rerenders happen */
    for(node= snode->edittree->nodes.first; node; node= node->next)
    if(node->flag & SELECT)
    if(node->id)
    ED_node_changed_update(node->id, node);
  • Date: 2011-01-08 20:11
  • Sender: Ton Roosendaal
  • Alexander: good discovery! I still couldn't get the crash, but the code was definitely bad... it got called with a wrong argument.
    Fix goes to svn now with credit :)
 

Attached Files:

Name Date Download
viewer-node-duplication_crash.blend 2011-01-08 17:48 Download

Changes:

Field Old Value Date By
status_idOpen2011-01-08 20:11ton
close_dateNone2011-01-08 20:11ton
StatusInvestigate2011-01-08 20:11ton
File Added14436: viewer-node-duplication_crash.blend2011-01-08 17:48daccy
summaryDuplicating (Split)Viewer node in Compositor crashes Blender2011-01-07 05:43campbellbarton
assigned_tonone2011-01-07 05:15campbellbarton
StatusNew2011-01-07 05:15campbellbarton