Blender Foundation: Blender 2.x BF release: Detail: 25951 Hardcoded Keys in PoseLib modal operator register twice per use

Log In
New Account

[#25951] Hardcoded Keys in PoseLib modal operator register twice per use

Date:
2011-02-06 14:31 Priority:
3

State:
Closed

Submitted by:
Daniel Salazar (zanqdo) Assigned to:
Joshua Leung (aligorith)

Category:
Animation system Status:
Fixed / Closed

Relates to: Duplicates:

Patches:

Summary:
Hardcoded Keys in PoseLib modal operator register twice per use

Detailed description

During poselib browse operator, press for example PAGEDOWNKEY. It will trigger twice, one for press, once for release. Tracked this one to poselib_preview_handle_event in poselib.c. Seems it's using hardcoded cases. Probably same problem in other places surrounding this?

cheers

Followup

Message

Date: 2011-02-06 19:19
Sender: Ton Roosendaal
Hi Joshua,

Since poselib_preview_handle_event() only does hot keys, a single check for event->val==KM_PRESS should be sufficient.
I'm not familiar with the functionality here though... I might break stuff. :)

Date: 2011-02-06 23:21
Sender: Joshua Leung
Yep, that seems to do the trick :)

I've added a commented out debug print there in case we have any more events debugging to do later :)

Attached Files:

No Files Currently Attached

Changes:

Field	Old Value	Date	By

status_id	Open	2011-02-06 23:21	aligorith
close_date	None	2011-02-06 23:21	aligorith
Status	New	2011-02-06 23:21	aligorith