Only search projects.blender.org
 Log In
New Account
Home My Page Projects Blender 2.x BF release
Summary Activity Tracker SCM Files

Blender 2.6 Bug Tracker: Browse

[#26432] Ctrl+Z empties render slots other than current one

Date:
2011-03-09 17:21		 Priority:
3
State:
Closed
Submitted by:
Luca Thesal (reporter) 		Assigned to:
Ton Roosendaal (ton)
Category:
Interface		 Status:
Fixed / Closed
Relates to:
Duplicates:
Patches:
 
Summary:
Ctrl+Z empties render slots other than current one
Detailed description
Thanx a lot for fixing bug [#26424], that's really fast! :)

This is something related to that bug:

1. render a scene in slot 1
2. swap to slot 2 make a little change to the scene (like move your camera a bit) and render again
3. swap to slot 3, make a little change and re-render
4. swap to slot 4, change again your object position then render
5. have a look at the render slots cycling them with J key, they're all full with successive renders...
6. ...now hit Ctrl+Z to undo last camera/object move and all render slots suddenly became empty except the current one

No .blend attached because even the startup file is good to testing, anyway you'd have to follow those steps to have at least some render in your slots.

System specs:
Linux 64 bit
Nvidia card with GeForce 260.19.36
Blender SVN 35433 compiled with scons and Blender 2.56a 64 bit official Beta

Thanks a lot for your hard work!

Followup

Message
  • Date: 2011-03-09 20:06
  • Sender: Ton Roosendaal
  • Hrm... thats what you get, quick fixing other people's code.
    That means these 'slots' are not UI, but stored as scene data or so... will check tomorrow!
  • Date: 2011-03-10 18:39
  • Sender: Ton Roosendaal
  • I've managed to make it work, but the code for this feature still has a limitation:

    - Undo storage for switching slots is now back, but only when new
    buffers were added (not when viewing existing)

    - A real bug: On undo/redo, the stored buffers were never
    retrieved, but always freed entirely.

    Note however that when you undo back to a state before you
    rendered (or added slots), the render buffers that didn't
    exist back then also get freed. A redo doesn't bring it back.

    What does work now is undo-ing the steps after you rendered or viewed slots.
    It works similar to how other images in Blender are handled (textures, nodes).

    Please check, and if there's still issues just post here. I also read and reply to closed reports. That way all problems related to a report stick together nicely here.

    Thanks!
  • Date: 2011-03-11 11:51
  • Sender: Luca Thesal
  • Ok Ton, just checked and I think your solution is quite a good compromise, but as for this

    " - Undo storage for switching slots is now back, but only when new
    buffers were added (not when viewing existing) "

    it seems not working here (build 35471), it seems J key is taken in account in the undo history even when you just *see* different slots cycling them with J or Alt+J and not only when you add a new slot.. can you confirm or have I misunderstood? Thanks!
  • Date: 2011-03-12 16:09
  • Sender: Ton Roosendaal
  • Hi,

    Thanks for keeping on top of this :)
    It appeared that only when you switch to a slot that shows 'current render' an undo step was stored. Will commit a tweak for this too.
 

Attached Files:

No Files Currently Attached

Changes:

Field Old Value Date By
status_idOpen2011-03-10 18:39ton
close_dateNone2011-03-10 18:39ton
StatusInvestigate2011-03-10 18:39ton
assigned_tonone2011-03-09 20:06ton
StatusNew2011-03-09 20:06ton