Alaska Alaska
  • Just a cat helping with the development of Blender.

    Thank you Blender developers for doing everything you do.

  • Joined on 2018-10-10
Alaska created branch fix-transmission-osl in Alaska/blender 2023-08-16 02:57:04 +02:00
Alaska opened issue blender/blender#111156 2023-08-16 02:43:11 +02:00
Principled BSDF doesn't render transmission correctly with OSL
Alaska commented on pull request blender/blender#110993 2023-08-16 02:27:50 +02:00
Cycles: Rework Principled BSDF Clearcoat

The CoatIOR in closure color CoatBSDF = dielectric_bsdf(CoatNormal, vector(0.0), color(1.0), color(0.0), coat_r2, coat_r2, CoatIOR, "ggx"); also needs to be set to max(CoatIOR, 1.0) to avoid issues when CoatIOR is below 1.0.

Alaska commented on pull request blender/blender#110993 2023-08-16 02:27:41 +02:00
Cycles: Rework Principled BSDF Clearcoat

There's still a mismatch between Cycles SVM, Cycles OSL, and EEVEE.

When the coat IOR is below or at 1.0, all three behave differently.

  • Cycles SVM behaves like IOR is 1.0 and there are no…
Alaska commented on issue blender/blender#111125 2023-08-16 01:47:24 +02:00
4.0A producing specular reflections of area lights on diffuse surfaces, 3.6.1 doesn't behave this way.

What is your IOR? If it isn't 1.0, then reflections will appear. This is caused by a recent change to the Principled BSDF made by @LukasStockner .

This may seem like a weird change, but from my…

Alaska commented on pull request blender/blender#110993 2023-08-15 13:12:32 +02:00
Cycles: Rework Principled BSDF Clearcoat

Remove the full stop from the end of "Typically should be zero or one for physically-based materials.". The Blender UI already adds a full stop to the end.

Alaska commented on pull request blender/blender#110993 2023-08-15 12:58:43 +02:00
Cycles: Rework Principled BSDF Clearcoat

I also noticed a weird behavior with certain coat colours and device configurations.

If the coat tint has a blue channel set to 0, and you're rendering with the CPU, then the coat will appear…

Alaska commented on issue blender/blender#109847 2023-08-15 09:07:15 +02:00
Regression: Inconsistent panning in editors

I would like to pin @JulianEisel again to look into this issue or the pull request that has been made to fix this issue.

Alaska commented on pull request blender/blender#110993 2023-08-15 06:55:12 +02:00
Cycles: Rework Principled BSDF Clearcoat

This results in Blender crashing on the Metal backend for Blender/EEVEE. You can find the error message below.

Alaska commented on pull request blender/blender#110993 2023-08-15 06:52:57 +02:00
Cycles: Rework Principled BSDF Clearcoat

Running a quick test, I can identify a few issues.

  1. Blender crashes when using EEVEE with this pull request on the Metal backend for Blender (Tested with a M1 Pro). I haven't done much…
Alaska commented on pull request blender/blender#110993 2023-08-10 15:02:57 +02:00
Cycles: Rework Principled BSDF Clearcoat

Replacing if (coat_tint != one_float3()) with if (!isequal(coat_tint, one_float3())) fixes compilation issues with the Metal backend.

Alaska commented on pull request blender/blender#110993 2023-08-10 12:38:34 +02:00
Cycles: Rework Principled BSDF Clearcoat

This is probably unintentional so that's why I'm reporting it.

Changing the Coat Tint colour while the coat parameter is set to 0 still has an impact on the material. ![Clear coat…

Alaska commented on issue blender/blender#109841 2023-08-08 02:32:39 +02:00
Rendering error

This issue will be fixed by #110907 once it is merged with main.

Alaska deleted branch fix-small-sun-light-tree-sampling from Alaska/blender 2023-08-07 09:35:03 +02:00
Alaska commented on pull request blender/blender#105662 2023-08-03 15:06:05 +02:00
MacOS: Enable support for EDR rendering

and also still have to address the HDR monitor availability idea from Brecht, but hopefully that should be the last of it for the initial implementation.

Just confirming, this patch is for…

Alaska pushed to fix-small-sun-light-tree-sampling at Alaska/blender 2023-07-31 15:24:01 +02:00
90e276682b Use isequal() approach for fixing sampling issues with small sun
84c0d28eb0 Add back kernel_assert
cc34867351 Update code comment
f774efeb1a Fix increased noise in some situations
0d6b568fd2 Fix #110255: Cover up CPU/GPU differences in light tree.
Compare 260 commits »
Alaska deleted branch fix-nan-light_tree from Alaska/blender 2023-07-31 15:13:25 +02:00
Alaska deleted branch clean_up_update_lights from Alaska/blender 2023-07-31 15:13:09 +02:00
Alaska deleted branch light_tree_con_simplify_get_co from Alaska/blender 2023-07-31 15:13:05 +02:00
Alaska commented on pull request blender/blender#110307 2023-07-26 09:46:29 +02:00
Fix #110255: Cover up CPU/GPU differences with small suns in light tree

I just wanted to add a comment.

As pointed out earlier, the rendering error occurring on the GPU but not the CPU was due to floating point precision differences between the dot() function on…