Martijn Versteegh Baardaap
0 Followers · 0 Following
  • Joined on 2020-06-24
Overview Repositories
3
 Projects Public Activity Starred Repositories
Martijn Versteegh commented on pull request blender/blender#109083 2023-06-17 21:39:41 +02:00
WIP: Make ComponentAttributeAccessor handle active/default_color_attribute

I think I solved the issue with the remove handler being wrong.

Martijn Versteegh pushed to addremovetrigger at Baardaap/blender 2023-06-17 21:23:20 +02:00
1e69a6ac4b Don't bother checking anonymous attributes for being active/default_color_attribute
Martijn Versteegh pushed to addremovetrigger at Baardaap/blender 2023-06-17 21:03:39 +02:00
23356efa98 -Trigger -> Handler
Martijn Versteegh commented on pull request blender/blender#109083 2023-06-17 18:29:13 +02:00
WIP: Make ComponentAttributeAccessor handle active/default_color_attribute

Iliya suggested (i the chat) to use 'handler' instead of 'trigger' for the function names. Which is better I agree.

Also I have my doubts about the delete handler because:

  • it gets called for…
Martijn Versteegh pushed to addremovetrigger at Baardaap/blender 2023-06-17 18:11:22 +02:00
75191ba54d Cleanup: make format
Martijn Versteegh commented on pull request blender/blender#109083 2023-06-17 18:10:40 +02:00
WIP: Make ComponentAttributeAccessor handle active/default_color_attribute

I think this is a better way to do what #109067 did as well.

Martijn Versteegh closed pull request blender/blender#109067 2023-06-17 18:10:10 +02:00
WIP Geometry Nodes: Set first created color attribute to active
Martijn Versteegh commented on pull request blender/blender#109067 2023-06-17 18:09:45 +02:00
WIP Geometry Nodes: Set first created color attribute to active

I think #109083 is a better (more general) solution.

Martijn Versteegh created pull request blender/blender#109083 2023-06-17 18:08:45 +02:00
WIP: Make ComponentAttributeAccessor handle active/default_color_attribute
Martijn Versteegh created branch addremovetrigger in Baardaap/blender 2023-06-17 18:06:38 +02:00
Martijn Versteegh pushed to addremovetrigger at Baardaap/blender 2023-06-17 18:06:38 +02:00
90e509d86d Make ComponentAttributeAccessor handle active/default_color_attribute
Martijn Versteegh commented on pull request blender/blender#109067 2023-06-17 10:00:04 +02:00
WIP Geometry Nodes: Set first created color attribute to active

Sleeping on it again I'm thinking maybe the mesh attribute provider add() function might be a better place for this logic?

Martijn Versteegh commented on pull request blender/blender#109067 2023-06-17 01:39:32 +02:00
WIP Geometry Nodes: Set first created color attribute to active

This is a bugfix for a reported issue. But as it's nearly 2am now I'll look up the related issue tomorrow.

Martijn Versteegh created pull request blender/blender#109067 2023-06-17 01:38:35 +02:00
WIP Geometry Nodes: Set first created color attribute to active
9a2bdb0482 Geometry Nodes: Set first created color attribute to active
4e7ee5d9ac Fix #108141: Group Insert operator creates invalid links
a6931db38b Fix: Build error without OpenEXR
17aaff69c6 Fix #109043: Mask modifier smooth option broken
d5781c2a61 Fix #109048: RenderLayer.load_from_file does not support multilayer EXR
Compare 7 commits »
Martijn Versteegh created branch set_first_color_attribute_active_gn in Baardaap/blender 2023-06-17 01:36:01 +02:00
Martijn Versteegh commented on issue blender/blender#107194 2023-06-16 15:46:46 +02:00
AttributeGroup API: "active" is meaningless (always refers to all attributes, not the specific AttributeGroup) -- e.g. mesh.color_attributes.active

I think this is not a bug per-se . It's more a case of bad documentation and a slightly clumsy api.

I think we could remove the hi prio

Martijn Versteegh created pull request blender/blender#109056 2023-06-16 15:18:15 +02:00
Fix #108053: Make the UV sets enumerated from zero
Martijn Versteegh pushed to fix-108053-collada-export at Baardaap/blender 2023-06-16 14:59:55 +02:00
5617dc042b Fix #108053: Make the UV sets enumerated from zero
6a05e5161b Fix: Quadratic performance of simulation state frame lookup
23eef18b65 Fix #109047: Screw modifier's smooth shading option does not work
57c3c68ffb Cleanup: make format
406a1f9bce Fix #108263: Show warning when cache baking wants to overwrite data
Compare 5 commits »
Martijn Versteegh created branch fix-108053-collada-export in Baardaap/blender 2023-06-16 14:59:55 +02:00