Martijn Versteegh Baardaap
  • Joined on 2020-06-24
Martijn Versteegh commented on issue blender/blender#108053 2023-06-16 09:12:01 +02:00
Collada Export: texcoord set="N" no longer starts at 0

I'll have a look.

Sounds like the collada exporter needs to restrict it's layer number by type as well as domain.

Martijn Versteegh commented on issue blender/blender#108343 2023-06-15 23:50:50 +02:00
render_color_index API is lost after GN mdifier

I think this one fixes it now:

Need to do some more testing tomorrow.

blender/blender#107066

Martijn Versteegh commented on pull request blender/blender#107066 2023-06-15 23:49:58 +02:00
WIP: Pass on color_attribute metadata through instancing, only for mesh

rebased onto blender-v3.6-release again.

I had to untangle some erroneous merges with main.

Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-06-15 23:46:36 +02:00
c3a8457b42 Actually use the stored names.
81acd760a3 Cleanup: simplify by using get_mesh_for_read()
ae5146dc61 If the 'instancer' mesh does not have an active/default color
e6db6ed09c DNA_mesh_types.h instead of BKE_mesh.h
41ec1cd98e Pass on color_attribute metadata through instancing, only for mesh
Compare 13 commits »
Martijn Versteegh commented on pull request blender/blender#107066 2023-06-15 10:29:52 +02:00
WIP: Pass on color_attribute metadata through instancing, only for mesh

rebased onto blender-v3.6-release

Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-06-15 10:28:57 +02:00
f5c52ce17f Cleanup: simplify by using get_mesh_for_read()
0c5806de48 If the 'instancer' mesh does not have an active/default color
6f5c092695 DNA_mesh_types.h instead of BKE_mesh.h
6bbe38d376 Pass on color_attribute metadata through instancing, only for mesh
d61d2e5f59 Fix #108911: Fcurve Proportional editing circle draws wrong
Compare 154 commits »
Martijn Versteegh commented on pull request blender/blender#107066 2023-06-15 08:49:48 +02:00
WIP: Pass on color_attribute metadata through instancing, only for mesh

I think the conclusion from the last module meeting was that the thing this patch does for instances should be done for joining as well. I'll try to update the patch and add join handling.

Martijn Versteegh commented on pull request blender/blender#108319 2023-06-14 16:15:49 +02:00
WIP : Use an extra step of indirection in accessing CustomDataLayers via rna.

I'm currently at the stage where I'm trying to get it to work with the extra lookup table, however I'm not sure how feasible it is either, since the CustomData struct is copied (verbatim) in…

Martijn Versteegh opened issue blender/blender#108754 2023-06-08 13:33:40 +02:00
Test bf_imbuf_save fails with an asser in debugmode for v3.6-release
Martijn Versteegh commented on issue blender/blender#107468 2023-06-06 11:21:22 +02:00
Regression: Cycles environment map rotation is much slower in 3.5.1

Ah, I needed to set the world opacity to 1 instead of the (default) 0 to see the built in hdri.

Still no perceptible difference between LT on/off here.

Martijn Versteegh commented on issue blender/blender#107468 2023-06-02 15:00:56 +02:00
Regression: Cycles environment map rotation is much slower in 3.5.1

I don't see much of difference between LT on/off.

@Rawalanche what 'rotation slider' are you using. I didn't see any steps for setting up a hdri in your 'steps to reproduce'.

I set up an 8k…

Martijn Versteegh commented on pull request blender/blender#108319 2023-06-01 13:52:18 +02:00
WIP : Use an extra step of indirection in accessing CustomDataLayers via rna.

I did some work trying to remove the CustomDataLayer ** table and replace it with a layer_uuid. But got stuck on the fact that I can store the uuid in the PointerRNA.data pointer (just by…

Martijn Versteegh commented on issue blender/blender#108343 2023-05-31 13:32:51 +02:00
render_color_index API is lost after GN mdifier

Looking into this it is related, but a slightly different code path, which this patch does not solve.

the patch solves propagating the active/render color index across instancing, while this…

Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-05-29 11:28:28 +02:00
0068cd0771 Merge branch 'main' into pass_active_color_to_instances
1f3a0fbad8 Command line argument --open-last exists if the file isn't found
d958a5dd24 Refactor: split file loading into its own function
260eabba8f Merge branch 'blender-v3.6-release'
2d81e65703 Fix failure to load a blend file behaving as if a new file is loaded
Compare 308 commits »
Martijn Versteegh commented on issue blender/blender#108343 2023-05-28 15:39:19 +02:00
render_color_index API is lost after GN mdifier

I'll try to find the time to get my brain back into the space of that patch and see what's missing from it and how it could be done differently...

Martijn Versteegh commented on issue blender/blender#108343 2023-05-28 15:31:05 +02:00
render_color_index API is lost after GN mdifier

It should ate least be predictable what happens. To me 'pick the first one' would be ok. Combined with an explicit 'set active color index' node or something like that.

Martijn Versteegh commented on issue blender/blender#108343 2023-05-28 13:58:03 +02:00
render_color_index API is lost after GN mdifier

At a first glance I guess this is the same problem as: blender/blender#106563

I don't have much time to really look into it this weekend though. Do you…

Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-05-27 00:15:37 +02:00
8de18aef7b Merge branch 'blender-v3.6-release' into pass_active_color_to_instances
9e83211b8d Fix: Implement shared Metal Command queue to resolve sync bugs
ccd85688ed Update licence infos for OpenSSL.
001e012ea0 Fix crash when selecting all bones in armature
080484a5c8 Fix #108125: Cycles generates NaN in render passes with low roughness
Compare 783 commits »
Martijn Versteegh commented on issue blender/blender#107416 2023-05-26 22:08:14 +02:00
Debug assert in uv layer data.foreach_get when called on an Edit Mode mesh

Initial investigation results:

  • foreach_attr_type tries to get the type of the MeshUVLoopLayer.data.uv property
  • because the object is in edit mode, the length of the .data collection is 0 -…
Martijn Versteegh commented on issue blender/blender#107194 2023-05-26 16:54:42 +02:00
AttributeGroup API: "active" is meaningless (always refers to all attributes, not the specific AttributeGroup) -- e.g. mesh.color_attributes.active

Just as PSA: I don't have time to look into this at the moment. In case someone hoped I would ;-)