Martijn Versteegh Baardaap
  • Joined on 2020-06-24
Martijn Versteegh commented on issue blender/blender#110334 2023-07-23 11:07:57 +02:00
crash while setting vertices positions using foreach_set

I didn't yet really look into it, but my guess is that the python error disappearing happens because the position access changed from a specilaized CustomData array accessor to accessing it as an…

Martijn Versteegh pushed to main at blender/blender 2023-07-18 09:56:19 +02:00
b199f10204 Fix #110164: Trigger spreadsheet redraw on animation pause
Martijn Versteegh deleted branch update-spreadsheet-on-pause from Baardaap/blender 2023-07-18 09:56:19 +02:00
Martijn Versteegh merged pull request blender/blender#110224 2023-07-18 09:56:18 +02:00
Fix #110164: Trigger spreadsheet redraw on animation pause
Martijn Versteegh pushed to update-spreadsheet-on-pause at Baardaap/blender 2023-07-18 09:48:24 +02:00
6e82de03ca Merge branch 'main' into update-spreadsheet-on-pause
7fe1f14116 BLI_linklist_stack: restore type safety without needing explicit casts
e9dbb68729 Fix: Eevee-next LOD selection
ac9f66e742 Cleanup: correct struct member comments
db345366fe Cleanup: struct member comments for DrawEngineType & RenderEngineType
Compare 8 commits »
Martijn Versteegh created pull request blender/blender#110224 2023-07-17 23:12:46 +02:00
Fix #110164: Trigger spreadsheet redraw on animation pause
Martijn Versteegh created branch update-spreadsheet-on-pause in Baardaap/blender 2023-07-17 23:10:45 +02:00
Martijn Versteegh pushed to update-spreadsheet-on-pause at Baardaap/blender 2023-07-17 23:10:45 +02:00
cdd1b17bcb Fix #110164: Trigger spreadsheet redraw on animation pause
eec5c867d3 Cleanup: Make format
899f8a8500 Refactor: use ImBuf instead of a raw buffer for compositor previews
b767a62f32 Fix #109679: Normal Map node strength interpolation artifacts
69cc84fa6c Cleanup: Make format
Compare 10 commits »
Martijn Versteegh commented on issue blender/blender#110164 2023-07-17 22:03:35 +02:00
Spreadsheet does not update during/after playing animation

Probably that causes it. But I'd think a redraw of the spreadsheet area could be triggered without a new depsgraph evaluation. As seems to be implied for that patch, though I guess that patch…

Martijn Versteegh commented on issue blender/blender#110164 2023-07-17 11:13:14 +02:00
Spreadsheet does not update during/after playing animation

I'll try to create a patch+PR myself ;-)

Martijn Versteegh commented on issue blender/blender#110164 2023-07-17 11:12:28 +02:00
Spreadsheet does not update during/after playing animation

No, when I enable that option everything works. what does not work, and is somewhat unexpected imho is:

  • press play
  • press pause

Spreadsheet shows info from before you pressed play. As…

Martijn Versteegh commented on issue blender/blender#110164 2023-07-16 18:51:42 +02:00
Spreadsheet does not update during/after playing animation

I'd still expect it to update after you've pressed the pause button.

As it is it now shows stale data when the animation is no longer playing. Which is doesn't happen anywhere else in blender I…

Martijn Versteegh opened issue blender/blender#110164 2023-07-16 10:45:10 +02:00
Spreadsheet does not update during/after playing animation
Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-07-13 01:47:11 +02:00
6f84d27c61 Port geometry component type check to new method.
Martijn Versteegh pushed to pass_active_color_to_instances at Baardaap/blender 2023-07-13 00:58:08 +02:00
3f83adf70f Cleanup: simplify by using get_mesh_for_read()
3ffc9f360c If the 'instancer' mesh does not have an active/default color
f32328293f DNA_mesh_types.h instead of BKE_mesh.h
fb36767d88 Pass on color_attribute metadata through instancing, only for mesh
aa700821a8 Extern: Update NanoSVG
Compare 1664 commits »
Martijn Versteegh closed pull request blender/blender#106972 2023-07-12 14:39:27 +02:00
Make first non-anonymous CustomData layer active
Martijn Versteegh commented on issue blender/blender#109670 2023-07-06 22:21:43 +02:00
Regression: Attributes shared between meshes after modification

Yes, it would be nice to handle it automatically. The changing pointers makes that tricky though, I haven't thought of a way to make that work yet. We'd need to store the CustomDataLayer

Martijn Versteegh commented on issue blender/blender#109670 2023-07-06 01:14:31 +02:00
Regression: Attributes shared between meshes after modification

I didn't really consider it. For Python scripts I guess it's simplest if we can hide this, and automatically make the attribute mutable whenever RNA set is called. But then you need to store…

Martijn Versteegh deleted branch fix-107416-assert-on-zero-length-mloopuv_data from Baardaap/blender 2023-07-05 20:06:28 +02:00
Martijn Versteegh pushed to main at blender/blender 2023-07-05 20:06:28 +02:00
a280e8a68c Fix #107416: Check length of Property Collection before type