Bill-Spitzak
  • Joined on 2024-02-16
Bill-Spitzak commented on issue blender/blender#124842 2024-11-20 04:45:05 +01:00
CPU compositor Translate sets left and bottom edge to blank pixels

Without this the CPU and GPU compositor results are different from each other, which means a 100% chance of the next version being incompatible. I think it would be a good idea to put this into…

Bill-Spitzak commented on issue blender/blender#126263 2024-08-15 05:18:27 +02:00
Vulkan: Add support for hardware based device selections (PRIME/AMD Dynamic Graphics Selection)

Newest version seems to have reversed things! This was compiled 8/14/24. Now running vulkan with no .blend file on the command line hangs. After about 5 seconds CPU usage drops to zero, nothing…

Bill-Spitzak commented on issue blender/blender#126263 2024-08-13 18:05:53 +02:00
Vulkan: Add support for hardware based device selections (PRIME/AMD Dynamic Graphics Selection)

Commenting out the BLI_assert and two other identical ones just leads to a crash.

Bill-Spitzak commented on issue blender/blender#126263 2024-08-13 18:02:05 +02:00
Vulkan: Add support for hardware based device selections (PRIME/AMD Dynamic Graphics Selection)

Tried the newest build, it crashes immediately for me when choosing the Save System Info menu item, with same error. Running without --gpu-backend vulkan does not crash. `BLI_assert failed:…

Bill-Spitzak commented on issue blender/blender#126263 2024-08-13 06:33:10 +02:00
Vulkan: Add support for hardware based device selections (PRIME/AMD Dynamic Graphics Selection)

Here is a possibly more accurate system-info.txt, this is from running the GPU option __NV_PRIME_RENDER_OFFLOAD=1 __GLX_VENDOR_LIBRARY_NAME=nvidia for POP_OS "hybrid" mode. However I am unable…

Bill-Spitzak commented on issue blender/blender#126263 2024-08-13 06:25:16 +02:00
Vulkan: Add support for hardware based device selections (PRIME/AMD Dynamic Graphics Selection)

Jeroen Bakker said I should create this report

Bill-Spitzak opened issue blender/blender#126263 2024-08-13 06:24:46 +02:00
Vulkan crashes when .blend file given on command line
Bill-Spitzak deleted branch transform_math from Bill-Spitzak/blender 2024-08-02 21:25:51 +02:00
Bill-Spitzak commented on pull request blender/blender#125543 2024-08-02 21:25:40 +02:00
New math to compute matrix in realize_on_domain

I think I set the email now, thanks for noticing.

Bill-Spitzak deleted branch resolveshift from Bill-Spitzak/blender 2024-08-01 23:07:14 +02:00
Bill-Spitzak commented on pull request blender/blender#125267 2024-07-31 21:18:50 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Further push to remove change to GPU code that was merged to this branch for testing.

Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-31 21:17:57 +02:00
f7a12440c0 Fix #124842: Remove unused wrap_pixel(int,int...) function
e3c1d9bf6f Fix #124842: Fix Clipping in MemoryBuffer::read_elem_bilinear
8e613f05f6 Fix #124842: Fix clipping and Nearest sampling in COM_MemoryBuffer::read/read_elem_sampled
fcfcdef360 Sculpt: Data oriented refactor for mask filter
989fcc2c4f UI: Mouse Event Icon Alignment
Compare 127 commits »
Bill-Spitzak commented on pull request blender/blender#125543 2024-07-31 20:37:34 +02:00
New math to compute matrix in realize_on_domain

I think you are talking about rotated (or otherwise transformed) output domains?

Because of the simpler handling of the output transform matrix I suspect my code is either unchanged or is…

Bill-Spitzak commented on pull request blender/blender#125543 2024-07-31 20:17:03 +02:00
New math to compute matrix in realize_on_domain

I don't get it. I can clearly tell that rotations call this code (since I could see rotations fail when I did it incorrectly).

Bill-Spitzak commented on pull request blender/blender#125543 2024-07-31 20:04:43 +02:00
New math to compute matrix in realize_on_domain

There is currently no rotation or scaling when doing realizations, only translations. That's why we won't really know if something fails until we get some rotation and scaling components as…

Bill-Spitzak commented on pull request blender/blender#125267 2024-07-31 19:58:45 +02:00
Fix #124842: Made CPU transforms match the GPU ones

I pushed a new version that moves the constant test to the top of the function. Added a comment indicating that ignoring extend is on purpose.

Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-31 19:58:02 +02:00
ace542d0ad New math to compute matrix in realize_on_domain
ec0311fd64 Fix #124842: Remove unused wrap_pixel(int,int...) function
e367f27e5a Fix #124842: Fix Clipping in MemoryBuffer::read_elem_bilinear
3b99f0dbf8 Fix #124842: Fix clipping and Nearest sampling in COM_MemoryBuffer::read/read_elem_sampled
26b7ae888b Fix: deduplicate shared data when writing to file
Compare 18 commits »
Bill-Spitzak commented on pull request blender/blender#125267 2024-07-31 19:47:36 +02:00
Fix #124842: Made CPU transforms match the GPU ones

It's not there because I wanted Clip to work for constant buffers.

However it looks like the design is to ignore the extend for constant buffers. This is what the GPU is doing. So it seems ok…

Bill-Spitzak commented on pull request blender/blender#125543 2024-07-31 19:17:33 +02:00
New math to compute matrix in realize_on_domain

If you want to support non-affine transforms this is going to be needed.

While I have been unable to see any differences with realistic-sized images and the affine rotations and scales that the…