Bill-Spitzak
  • Joined on 2024-02-16
Bill-Spitzak commented on pull request blender/blender#113057 2024-07-30 19:29:21 +02:00
Vulkan: Enable as Experimental Option

Starting with the following .blend file on the command line hangs with a black non-full-screen window, but starting without a filename and then opening this same file works.

`../build_linux/bi…

Bill-Spitzak commented on pull request blender/blender#125543 2024-07-28 00:46:50 +02:00
New math to compute matrix in realize_on_domain

Fixed now. Bit of a panic there. Any opinions on whether the math library is wrong?

Bill-Spitzak pushed to transform_math at Bill-Spitzak/blender 2024-07-28 00:45:39 +02:00
27711035b4 New math to compute matrix in realize_on_domain
26b7ae888b Fix: deduplicate shared data when writing to file
Compare 2 commits »
Bill-Spitzak commented on pull request blender/blender#125543 2024-07-28 00:42:26 +02:00
New math to compute matrix in realize_on_domain

It looks like int2 / float does not produce a float2, it might be producing an int2. This might be considered a bug in the math library?

Bill-Spitzak commented on pull request blender/blender#125543 2024-07-28 00:35:32 +02:00
New math to compute matrix in realize_on_domain

Don't merge this, it is wrong.

Bill-Spitzak created pull request blender/blender#125543 2024-07-27 22:38:53 +02:00
New math to compute matrix in realize_on_domain
Bill-Spitzak created branch transform_math in Bill-Spitzak/blender 2024-07-27 22:36:43 +02:00
Bill-Spitzak pushed to transform_math at Bill-Spitzak/blender 2024-07-27 22:36:43 +02:00
3cce16a72c New math to compute matrix in realize_on_domain
79862c8cfa LineArt: bake should return CANCELLED when not applicable
95139263de Cleanup: Python: Remove unnecessary array length definition in curves API
2f15347f7c Fix: Empty span check for vert_all_faces_visible_get
e8c7fe8ab9 Fix: Out of bounds errors with FillDataMesh
Compare 10 commits »
Bill-Spitzak commented on pull request blender/blender#125267 2024-07-27 18:30:50 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Updated with new version to address comments.

It would be nice if all the functions were consistent about whether minx/y are subtracted from the index!

Bill-Spitzak commented on pull request blender/blender#125267 2024-07-27 18:28:04 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Futher investigation made me not use math::interpolate_nearest_fl as I am worried about it making a different decision about 0.5 than the clipping code. Uses the old function which does Extend…

Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-27 18:22:36 +02:00
9da8be538a Fix #124842: Remove unused wrap_pixel(int,int...) function
2203caf4dd Fix #124842: Fix Clipping in MemoryBuffer::read_elem_bilinear
b9d722d422 Fix #124842: Fix clipping and Nearest sampling in COM_MemoryBuffer::read/read_elem_sampled
edcc438f5f GPv3: Python: Add drawing API functions
6fac4707d5 Curves: Add Python API to remove and resize curves
Compare 66 commits »
Bill-Spitzak commented on pull request blender/blender#125267 2024-07-27 00:15:41 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Existing issue. Bicubic gets the other pixel samples for the filter using Extend mode and does not implement Repeat.

Bill-Spitzak commented on pull request blender/blender#125267 2024-07-27 00:13:17 +02:00
Fix #124842: Made CPU transforms match the GPU ones

The border condition is slightly different for Nearest than for the antialiased version. However it could calculate this 'm' value for both and use a different threshold.

Bill-Spitzak commented on pull request blender/blender#125267 2024-07-25 21:39:59 +02:00
Fix #124842: Made CPU transforms match the GPU ones

I pushed a new version that skips the steps you already applied and removes the bouding box changes for Scale.

Bill-Spitzak pushed to resolveshift at Bill-Spitzak/blender 2024-07-25 21:29:46 +02:00
18e9eecb8c Fix #124842: Remove unused wrap_pixel(int,int...) function
9341f1ae73 Fix #124842: Fix Clipping in MemoryBuffer::read_elem_bilinear
d3090f6e14 Fix #124842: Fix clipping and Nearest sampling in COM_MemoryBuffer::read/read_elem_sampled
debf616e02 Cleanup: Formatting
0b6a7ee1f3 Cleanup: Sculpt: Use C++ math types/functions for filters
Compare 139 commits »
Bill-Spitzak commented on pull request blender/blender#125267 2024-07-25 21:20:09 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Actually now I'm thinking of removing this. The pixels are ending up in the right place, it's just that the bounding box is somewhat wrong (which also means that a second scale to a fixed size…

Bill-Spitzak commented on pull request blender/blender#125267 2024-07-25 21:14:30 +02:00
Fix #124842: Made CPU transforms match the GPU ones

Probably a good idea to force the size, my version could move one edge when not moving the other, which I think is what produced your errors. Any particular scale or input size that you observed…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-25 20:28:30 +02:00
Fix #124133: Transforms shift due to incorrect floor()

You are probably right that alternating shift does not need to be put in unless the current scheme actually demonstrates a problem. Also I think all this will have to be changed to use `displayWind…

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-24 21:28:45 +02:00
Fix #124133: Transforms shift due to incorrect floor()

Done (I hope).

Bill-Spitzak commented on pull request blender/blender#124381 2024-07-24 21:28:31 +02:00
Fix #124133: Transforms shift due to incorrect floor()

Done