BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

BLEN-335: Export environment light #1

Merged
Bogdan Nagirniak merged 13 commits from BLEN-335 into hydra-render 2023-02-17 14:46:46 +01:00
Conversation 0 Commits 13 Files Changed 9 +7 -1
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c811af052d - Show all commits

2
source/blender/render/hydra/sceneDelegate/blenderSceneDelegate.cc
View File

@ -77,7 +77,7 @@ bool BlenderSceneDelegate::GetVisible(SdfPath const &id)
HdRenderIndex &index = GetRenderIndex(); HdRenderIndex &index = GetRenderIndex();
if (index.GetSprim(HdPrimTypeTokens->domeLight, id)) { if (index.GetSprim(HdPrimTypeTokens->domeLight, id)) {
return true; return world_data.is_visible();
} }
return obj_data->is_visible(); return obj_data->is_visible();

5
source/blender/render/hydra/sceneDelegate/world.cc
View File

@ -80,6 +80,11 @@ void WorldData::update_world()
set_as_world(); set_as_world();
} }
bool WorldData::is_visible()
{
return true;
}
void WorldData::set_as_world() void WorldData::set_as_world()
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak commented 2023-02-15 17:00:15 +01:00
Review
Copy Link

move to constructor

move to constructor
{ {
data.clear(); data.clear();

1
source/blender/render/hydra/sceneDelegate/world.h
View File

@ -32,6 +32,7 @@ public:
const T &get_data(pxr::TfToken const &key); const T &get_data(pxr::TfToken const &key);
bool has_data(pxr::TfToken const &key); bool has_data(pxr::TfToken const &key);
void update_world(); void update_world();
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak commented 2023-02-15 17:03:05 +01:00
Review
Copy Link

no need update_world() just recreate it in scene delegate

no need update_world() just recreate it in scene delegate
bool is_visible();
BL::Context *b_context; BL::Context *b_context;
View3DShading *shading; View3DShading *shading;