BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Need to do the same light power as Cycles in Watts for Hydra RPR #34

Merged
Bogdan Nagirniak merged 12 commits from BLEN-386 into hydra-render 2023-05-05 08:42:35 +02:00
Conversation 0 Commits 12 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 212434497f - Show all commits

4
source/blender/render/hydra/scene_delegate/light.cc
View File

@ -32,14 +32,14 @@ void LightData::init()
if (scene_delegate_->engine_type == BlenderSceneDelegate::EngineType::PREVIEW) { if (scene_delegate_->engine_type == BlenderSceneDelegate::EngineType::PREVIEW) {
intensity *= 0.001f; intensity *= 0.001f;
Bogdan Nagirniak commented 2023-05-03 09:45:15 +02:00
Outdated
Review
Copy Link

Do we still need this multiplication?

Do we still need this multiplication?
} }
//intensity *= 0.001f;
data_[pxr::HdLightTokens->color] = pxr::GfVec3f(light->r, light->g, light->b); data_[pxr::HdLightTokens->color] = pxr::GfVec3f(light->r, light->g, light->b);
switch (light->type) { switch (light->type) {
case LA_LOCAL: case LA_LOCAL:
data_[pxr::HdLightTokens->radius] = light->radius; data_[pxr::HdLightTokens->radius] = std::max(light->radius, 0.000001f);
Bogdan Nagirniak commented 2023-05-03 09:47:02 +02:00
Outdated
Review
Copy Link

if radius == 0, maybe data_[pxr::UsdLuxTokens->treatAsPoint] = true; ?

if radius == 0, maybe `data_[pxr::UsdLuxTokens->treatAsPoint] = true;` ?
data_[pxr::HdLightTokens->normalize] = true; data_[pxr::HdLightTokens->normalize] = true;
intensity /= 40.0f;
break; break;
case LA_SUN: case LA_SUN:
Brian Savery (AMD) commented 2023-05-03 18:51:37 +02:00
Outdated
Review
Copy Link

This seems like a strange value. How was this found?

This seems like a strange value. How was this found?
Georgiy Markelov commented 2023-05-04 10:17:22 +02:00
Outdated
Review
Copy Link

Every value has been found empirically.

Every value has been found empirically.