YimingWu ChengduLittleA
  • Joined on 2014-05-03
YimingWu closed issue blender/blender#129859 2024-11-05 16:35:34 +01:00
GPv3: Workaround missing Bezier handle support in modifiers
YimingWu merged pull request blender/blender#129860 2024-11-05 16:35:31 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves
YimingWu pushed to blender-v4.3-release at blender/blender 2024-11-05 16:35:30 +01:00
46b89b2aa4 Fix: GPv3: Some modifiers not working with non-poly curves
YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 16:05:29 +01:00
82f64c761a remove empty check from resample_to_evaluated
YimingWu commented on pull request blender/blender#129860 2024-11-05 15:38:22 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

OK I cleaned this up to use ensure_no_bezier_curves

YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 15:37:49 +01:00
75ed637af7 cleanups
YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 15:33:22 +01:00
40ae8fd896 use ensure_no_bezier_curves on drawing level
YimingWu commented on pull request blender/blender#129860 2024-11-05 14:43:17 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

I now std::move(curves) to the drawing after conversion, so should be alright now.

YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 14:43:00 +01:00
d81a11755b cleanups
YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 14:40:25 +01:00
fb0ddbdfd6 cleanups
YimingWu commented on pull request blender/blender#129860 2024-11-05 14:24:05 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

Sure, yeah, except for for_write which doesn't really make sense in this context. for_write is meant for functions that give mutable access to a shared resource.

Then I guess just…

YimingWu commented on pull request blender/blender#129860 2024-11-05 14:23:00 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

Like this:

const bke::CurvesGeometry src_curves = modifier::modifier::greasepencil::convert_to_poly_curves(drawing.strokes());

Ah ok so no need to have a & when getting the…

YimingWu commented on pull request blender/blender#129860 2024-11-05 14:20:34 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

Maybe naming it ensure_poly_curves_for_write() make it more clear on what it does? 🤔

YimingWu commented on pull request blender/blender#129860 2024-11-05 14:14:48 +01:00
Fix: GPv3: Some modifiers not working with non-poly curves

I see. What I wanted to do there is to have the function convert curves to poly and write it to src_curves_for_write when it needs to, and also return that same thing so at the places where…

YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 13:49:05 +01:00
48a8975012 Don't touch the field func
YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 13:45:32 +01:00
551a34cc73 Support catmull subdiv
312bf8d140 Cleanups
Compare 2 commits »
YimingWu created pull request blender/blender#129860 2024-11-05 13:44:12 +01:00
GPencil: Support non-poly curves for GPv3 modifiers
YimingWu pushed to gpv3-modifier-poly at ChengduLittleA/blender 2024-11-05 13:41:14 +01:00
27faf5b8ba GPencil: Support non-poly curves for GPv3 modifiers
b18a460ad7 Fix #129265: Clearing depth attachments on AMD official driver
6ba58a8303 Fix (unreported) unclear potential invalid readfile behavior on unknown BHead type.
2f6197daa9 Assets: Update assets repository hash for essentials library updates
a3b04dffbc Fix #129798: GPv3: Selection to Cursor/Grid missing immediate update
Compare 10 commits »
YimingWu created branch gpv3-modifier-poly in ChengduLittleA/blender 2024-11-05 13:41:14 +01:00