Christoph Lendenfeld ChrisLend
3 Followers · 0 Following
Overview Repositories
4
 Projects Public Activity Starred Repositories
Christoph Lendenfeld pushed to move_slot_to_new_action at ChrisLend/blender 2024-09-27 10:05:47 +02:00
42bac0d928 review comments
Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-27 10:05:18 +02:00
Anim: operator to move Slots to new action

copy and paste error from other parts of this file. Noted this file down for a cleanup pass later

Christoph Lendenfeld pushed to main at ChrisLend/.profile 2024-09-27 09:57:14 +02:00
4013c513be Update vectors_of_work.md
Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-27 09:49:03 +02:00
Anim: operator to move Slots to new action

in general, is std::optional preferred over default values?

Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-27 09:41:19 +02:00
Anim: operator to move Slots to new action

honestly I am not sure what either of those tags do exactly. I've just followed what the other operators in this file use

Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 17:42:40 +02:00
Anim: operator to move Slots to new action

I decided to hide the whole menu when baklava is disabled. That's because it would leave an empty menu behind otherwise which is really weird

Christoph Lendenfeld pushed to move_slot_to_new_action at ChrisLend/blender 2024-09-26 17:41:56 +02:00
3f3fb23504 only show menu when using the experimental flag
Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 17:32:35 +02:00
Anim: operator to move Slots to new action

We could unconditionally add the nla.bake operator here

I'd prefer to do that as a separate commit. I think for now it's easier if it's all new stuff

Christoph Lendenfeld pushed to move_slot_to_new_action at ChrisLend/blender 2024-09-26 17:28:32 +02:00
256a7c8378 review comments
00a28d8cd6 Merge branch 'main' into move_slot_to_new_action
bcd0d14943 Versioning for layered actions
5f8721d92a Fix #127964: Crash when baking from mesh with no faces
a1a00ec49c Fix: Uninitialized variable in versioning code
Compare 23 commits »
Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 16:50:33 +02:00
Anim: operator to move Slots to new action

should the merge animation operator then also be behind the experimental flag

Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 16:38:11 +02:00
Anim: operator to move Slots to new action

I'll do it in this PR so it's easy to see why it was done

Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 16:37:45 +02:00
Anim: operator to move Slots to new action

had to change to Action * for that to work

Christoph Lendenfeld commented on pull request blender/blender#128171 2024-09-26 16:31:00 +02:00
Anim: operator to move Slots to new action

thanks for catching that, makes sense

Christoph Lendenfeld pushed to main at ChrisLend/blender 2024-09-26 15:51:47 +02:00
bcd0d14943 Versioning for layered actions
5f8721d92a Fix #127964: Crash when baking from mesh with no faces
a1a00ec49c Fix: Uninitialized variable in versioning code
147d8aad54 Anim: Show Action Slot type in panel + change type icon RNA prop
3cfeebe7c7 glTF exporter: fix crash managing shader node groups
Compare 21 commits »
Christoph Lendenfeld deleted branch layered_action_versioning from ChrisLend/blender 2024-09-26 15:46:15 +02:00
Christoph Lendenfeld pushed to main at blender/blender 2024-09-26 15:46:12 +02:00
bcd0d14943 Versioning for layered actions
Christoph Lendenfeld merged pull request blender/blender#127842 2024-09-26 15:46:11 +02:00
Versioning for layered actions
Christoph Lendenfeld pushed to main at ChrisLend/.profile 2024-09-26 15:45:22 +02:00
1a4dbb3047 Update reports/2024.md
Christoph Lendenfeld commented on pull request blender/blender#127842 2024-09-26 15:14:46 +02:00
Versioning for layered actions

@blender-bot build failed tests seem to have been unrelated to this PR but still want to see the tests pass

Christoph Lendenfeld pushed to layered_action_versioning at ChrisLend/blender 2024-09-26 15:14:04 +02:00
51e5734de0 used wrong tests hash
91917c1ab1 Revert "update test commit to main"
Compare 2 commits »