Amine Bensalem HamilcarR
0 Followers · 0 Following
  • Joined on 2023-09-08
Repositories
1
 Projects Public Activity Starred Repositories
Amine Bensalem pushed to editor-118137-symmetry_toolbar_sync at HamilcarR/blender 2024-02-20 14:36:39 +01:00
7863618b37 Cleanup
Amine Bensalem created pull request blender/blender#118508 2024-02-20 14:34:26 +01:00
Fix #118137: Symmetry buttons on-click state change
Amine Bensalem pushed to editor-118137-symmetry_toolbar_sync at HamilcarR/blender 2024-02-20 14:25:32 +01:00
c267639be2 Fix #118137: Toolbar symmetry buttons not updated on click.
Amine Bensalem created branch editor-118137-symmetry_toolbar_sync in HamilcarR/blender 2024-02-20 13:23:31 +01:00
Amine Bensalem pushed to editor-118137-symmetry_toolbar_sync at HamilcarR/blender 2024-02-20 13:23:31 +01:00
b77682f4db Fix : Synchronization between symmetry buttons in toolbar
c2b56ca468 Cleanup: prevent unnecessary copy of VArray
1e20f06c21 BLI: add utility to simplify creating proper random access iterator
4acbda91f8 Merge branch 'blender-v4.1-release'
a677518cb5 Fix #118351: Pixel Shift with Win32 Clipboard DibV5 Image Transfer
Compare 10 commits »
Amine Bensalem commented on issue blender/blender#118137 2024-02-17 17:14:26 +01:00
UI: missing update after changing the symmetry axis

Hi, thanks for the report. Can confirm. Looks like a missing notifier for redrawing the toolbar (and for editor panel).

Tagging with good first issue

Hi , I have noticed the buttons…

Amine Bensalem commented on issue blender/blender#118137 2024-02-15 03:49:29 +01:00
UI: missing update after changing the symmetry axis

I'm gonna take this one if you guys don't mind ;)

Amine Bensalem commented on issue blender/blender#114780 2024-02-15 02:18:50 +01:00
Improve Principled Hair Chiang importance sampling for tilt

little update : Those are single fibers samples , there's definitely a better specular highlight

Amine Bensalem closed issue blender/blender#118226 2024-02-14 10:37:18 +01:00
Possible math error in principled Chiang sampling function
Amine Bensalem commented on issue blender/blender#114780 2024-02-14 06:42:27 +01:00
Improve Principled Hair Chiang importance sampling for tilt

so , I'm finally starting to get a bit of results from the new version :

old render : chiang_old

new one : ![chiang_new](/attachment…

Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2024-02-14 06:21:55 +01:00
31a6ce82c8 Corrected TRRT+ for Mp in the sample function
a90d66543d Fix crash when alpha = 0
6aee065fd3 Merge branch 'main' into cycles-114780_chiang-hair
8f09fffef7 Cleanup: replace qsort with std::sort
f4f97ea979 Cleanup: comments in convexhull_2d, correct variable name
Compare 2424 commits »
Amine Bensalem opened issue blender/blender#118226 2024-02-14 00:57:09 +01:00
Possible math error in principled Chiang sampling function
Amine Bensalem commented on issue blender/blender#114780 2024-02-13 03:14:40 +01:00
Improve Principled Hair Chiang importance sampling for tilt

You can explain what to look for. I do have a background in computer graphics from my alma mater.

Amine, are you testing the single strand sheep hair that was mentioned or others as…

Amine Bensalem commented on issue blender/blender#114780 2024-02-12 21:31:58 +01:00
Improve Principled Hair Chiang importance sampling for tilt

@holly-l it's still relevant, though I'm not sure if @HamilcarR plans to continue work on this.

What I think the main thing to do is test this on an single close up hair strand, and…

Amine Bensalem commented on pull request blender/blender#114629 2024-02-11 11:48:56 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

it's done

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-11 11:47:37 +01:00
744d37c98c Cleanup : Removed unused function declarations
Amine Bensalem commented on pull request blender/blender#114629 2024-02-11 11:39:11 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

ah yes , good catch ... I'll remove node_cmp_rlayers_register_pass as well since it's not needed anymore ?

Amine Bensalem commented on pull request blender/blender#114629 2024-02-11 11:16:29 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

I put the call to update_node_declaration_and_sockets in ntreeCompositUpdateRLayers

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-11 11:14:28 +01:00
f30447ad0f Refractor : Removed call to node_cmp_rlayers_outputs
ee2bab5a3d Cleanup : Removed useless assert
Compare 2 commits »
Amine Bensalem commented on pull request blender/blender#114629 2024-02-11 08:38:31 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

Hey @mod_moder sorry for the (big) delay , had a bit on my plate lately... I brought most modifications you requested , except this one ... this one is a tough cookie to crack : I can't manage…