Amine Bensalem HamilcarR
0 Followers · 0 Following
  • Joined on 2023-09-08
Repositories
1
 Projects Public Activity Starred Repositories
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-10 21:06:20 +01:00
56506a2b08 Cleanup: Removed call to node_type_storage()
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-10 11:34:56 +01:00
9f553ec86d Merge branch 'main' into nodes-108728-cmp_node_r_layers
567a33ab32 BLI: Fix non-square matrix print (cout<<).
48390d018d Merge branch 'blender-v4.1-release'
55882e1fb0 Fix #118061: Tooltip Length Calculation Clipped for Enums
eaeaf8322c BLI: Bump SSE check from 4.1 to 4.2
Compare 2264 commits »
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-10 11:19:56 +01:00
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2024-02-10 10:53:37 +01:00
2c97fc1669 Removed node_type_storage function call
2f2b16777b Merge branch 'main' into nodes-108728-cmp_node_r_layers
48390d018d Merge branch 'blender-v4.1-release'
55882e1fb0 Fix #118061: Tooltip Length Calculation Clipped for Enums
eaeaf8322c BLI: Bump SSE check from 4.1 to 4.2
Compare 2262 commits »
Amine Bensalem commented on issue blender/blender#114780 2023-12-26 13:46:37 +01:00
Improve Principled Hair Chiang importance sampling for tilt

@Kanishk-Tiwari Still on it , I'm waiting for my new PC , the old one fried

Amine Bensalem commented on pull request blender/blender#114629 2023-12-16 17:51:28 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

My course work still require me to not relax and come back to blender, but i finally find the time to look in to this! Sorry for necromancy, i just tested this as it seems this works good.…

Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2023-11-27 10:02:45 +01:00
ea85357491 Fix : Hair chiang BSDF sample function
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-26 13:40:52 +01:00
3a8196fc23 Merge branch 'main' into nodes-108728-cmp_node_r_layers
9cc038f580 Fullframe compositor: unify behavior of size inference with realtime-compositor
b0cb58ca0e Fix #115368: Auto smooth node is added every time if the file has linked object
Compare 3 commits »
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-26 13:25:08 +01:00
5313e82181 Fix Compositor crash due to incorrect socket identifiers
Amine Bensalem commented on pull request blender/blender#114629 2023-11-26 11:48:18 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

Thanks for await. Just first first crash (that ocure only with this patch):

  1. Eevee render.
  2. Enable Viewport render.
  3. Enable Viewport realtime compositor in Viewport Settings. …
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-26 10:34:14 +01:00
fea3696a99 Fix compositor crash due to incorrect socket identifiers
c72f3777c9 Merge branch 'main' into nodes-108728-cmp_node_r_layers
8b188f0697 Cleanup : use socket names to check for combined rpass compatibility
2c2a7dda5b Replaced dynamic declare callback by dynamic callback.
e8a548c91c CLEANUP : Formating
Compare 149 commits »
Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2023-11-25 07:45:58 +01:00
21ee5c8859 Fix : Hair chiang BSDF sample function
Amine Bensalem commented on pull request blender/blender#115241 2023-11-24 08:47:36 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

How did you make the difference image? Using the images you provide I get this differnece.jpg

Hi , I just used the compositor :…

Amine Bensalem commented on pull request blender/blender#114629 2023-11-22 15:55:35 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

I'll just have to check this one this week, and we can move forward with this.

ok , let me know if you have questions

Amine Bensalem commented on pull request blender/blender#114629 2023-11-22 14:23:14 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

@mod_moder Hi , I think this is finally ready . I tested it with most nodes it seems to be working as intended . Do you want to test it on your side as well ? Maybe should I add some unit…

Amine Bensalem commented on pull request blender/blender#115241 2023-11-22 10:04:22 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

I now see the difference for the noise , but for the specularity , not at all , is it that subtle on this kind of fur ?

Amine Bensalem commented on pull request blender/blender#115241 2023-11-22 05:53:15 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

can you pinpoint the differences on the image if that doesn't bother you ? For example , I can see that there's a difference in colors , this is your version : ![old chiang](/attachments/f9d324…

Amine Bensalem commented on pull request blender/blender#115241 2023-11-21 21:02:45 +01:00
Fix #114780: Cycles: Principled Chiang Hair importance sampling correction

The Old image has the compositor enabled while the Corrected one does not.

Ah it's true . sorry , I don't know what results to expect yet , it's the first time I work with BSDFs . Still…

Amine Bensalem created pull request blender/blender#115241 2023-11-21 16:12:08 +01:00
WIP:Cycles: Fix #114780 : Importance sampling correction
Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2023-11-21 16:07:02 +01:00
87d098abc0 Cycles: Fix #114780 : Importance sampling correction