Amine Bensalem HamilcarR
  • Joined on 2023-09-08
Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2023-11-21 16:03:48 +01:00
37a99cafdc Cycles: Fix #114780 : Importance sampling correction
Amine Bensalem pushed to cycles-114780_chiang-hair at HamilcarR/blender 2023-11-21 15:41:29 +01:00
227a7d0f5c Cycles: Fix #114780 : Importance sampling correction
Amine Bensalem created branch cycles-114780_chiang-hair in HamilcarR/blender 2023-11-21 15:41:29 +01:00
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-21 08:06:59 +01:00
09db745021 Merge branch 'nodes-108728-cmp_node_r_layers'
d0e9468848 Fix (Unreported) VSE crash when editing retiming
918515495e Fix #115007: Crash when creating transition from last reiming key
8d2b203a3d Cleanup: Remove unnecessary keywords in C++ header
ea78af4b5d Cleanup: Move draw_subdivision.h to C++
Compare 16 commits »
Amine Bensalem commented on pull request blender/blender#114629 2023-11-20 20:13:39 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

Now it should be working . I updated the callback and renamed some stuff , should I re-merge main on the branch ?

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-20 20:12:27 +01:00
a813f7e743 Cleanup : use socket names to check for combined rpass compatibility
4942a8045c Replaced dynamic declare callback by dynamic callback.
Compare 2 commits »
Amine Bensalem commented on pull request blender/blender#114629 2023-11-20 17:32:06 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

Hi @mod_moder , I just pushed the merged updated main

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-20 17:29:36 +01:00
6a79a8cc20 Merge branch 'nodes-108728-cmp_node_r_layers'
b3d4fc80fd Fix: Duplicate node tools menus in sculpt mode
d638357d6f Fix: Vulkan Multi Indirect Drawing
07b5e1bd80 Fix #115153: Snap Base in Camera View crashes Blender
6ccb30246d Fix #114860: Edge bevel weights in complex solidify
Compare 1403 commits »
Amine Bensalem commented on pull request blender/blender#114629 2023-11-19 04:06:24 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

I have no idea why the script doesn't detect the clang-format binary in lib/ , I had to hard code the path into the script. I'll fix that later . I ran make format , added new commit for it.…

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-19 04:03:16 +01:00
13046f69a0 CLEANUP : Formating
Amine Bensalem commented on pull request blender/blender#114629 2023-11-18 19:58:31 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

make format raises an exception in the python wrapper : NotADirectoryError: [Errno 20] Not a directory: 'clang-format-8.0' I'm currently trying to fix this

Amine Bensalem commented on pull request blender/blender#114629 2023-11-18 16:11:10 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

In this case , what do you think would be the best way of doing things ? Maybe : `const char *socket_name = output->get_bnode_socket()->name ;

const char *pass_name = socket_name ;…

Amine Bensalem commented on pull request blender/blender#114629 2023-11-18 15:58:15 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

yep , it merges for me.

Amine Bensalem commented on pull request blender/blender#114629 2023-11-18 15:54:55 +01:00
Refractor: Compositor: Render layer node to dynamic declaration

this was clang-format ... I don't know why it corrected this line , and if I should let it do it's thing ... it's weird , because I use the exact same .clang-format as the official repo.

Amine Bensalem commented on pull request blender/blender#114629 2023-11-18 15:50:48 +01:00
Refractor: Compositor: Render layer node to dynamic declaration
  1. NodeImageLayer is no longer needed for socket storages as far as I understand , so I just removed it .
  2. The socket identifier part is to check if that socket can be used for the "RE_PASSNAME…
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-16 15:00:28 +01:00
488f8f0d67 CLEANUP : comment out unused function argument
Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-16 14:46:39 +01:00
acf1a114f7 CLEANUP : removed unecessary condition checks
Amine Bensalem commented on issue blender/blender#114780 2023-11-15 13:00:31 +01:00
Improve Principled Hair Chiang importance sampling for tilt

I'd like to give it a shot :)

Amine Bensalem pushed to nodes-108728-cmp_node_r_layers at HamilcarR/blender 2023-11-13 09:18:24 +01:00
87d5b54584 Refractor #108728: Removed now unused socket creation code.