Harley Acheson Harley
  • Joined on 2010-03-07
Harley Acheson commented on pull request blender/blender#107193 2023-04-22 20:56:58 +02:00
Refactoring: Corrections and unifications in mathematics vfont gizmos

From your code: A bit unsure of its meaning, the line...

Yikes, just a brain-fart. Change that to the following and you'll see I was just wanting to use the average rotation of the two…

Harley Acheson commented on pull request blender/blender#107193 2023-04-22 20:29:56 +02:00
Refactoring: Corrections and unifications in mathematics vfont gizmos

Wow that does work nicely. Is that much change really necessary though?

From what I can tell the fundamental problem in current code is simply that the positions of the text insertion cursor…

Harley Acheson commented on pull request blender/blender#106724 2023-04-22 01:48:04 +02:00
WIP: UI: Text cursor behavior for Apple Devices

@Austin Berenyi - Do not hesitate to ask questions or for clarification. We'll help you out as much or as little as you need. We'd like you to succeed.

Harley Acheson pushed to RegisterNew at Harley/blender 2023-04-22 00:40:02 +02:00
dcd0d4e55a Dealing with all users versus current user separately
21b51e7b88 Cleanup: Use function ref instead of pointer for transform gizmo
c547ff1ebd Fix VSE thumbnails are displayed from incorrect scene
968ecf6f8b Fix #106993: Slowness with Orbiting around select + Mesh Symmetry
7bf56e5c75 Fix failing lite build
Compare 82 commits »
Harley Acheson pushed to main at blender/blender 2023-04-21 19:28:53 +02:00
271ddc303d Fix Build Warning
Harley Acheson deleted branch TextObjectSelection from Harley/blender 2023-04-21 19:09:01 +02:00
Harley Acheson pushed to main at blender/blender 2023-04-21 19:08:58 +02:00
68f8253c71 VFONT: Text Selection Operator
Harley Acheson merged pull request blender/blender#106915 2023-04-21 19:08:58 +02:00
VFONT: Text Selection Operator
Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-21 18:56:32 +02:00
dd504e60b4 Use text cursor
Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-21 18:36:17 +02:00
6e60e1507f Changes suggested by review
Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-21 05:53:48 +02:00
f980840666 Make a tool for text selection.
587a61d16e function had one extra argument. Yikes
Compare 2 commits »
Harley Acheson commented on pull request blender/blender#107193 2023-04-21 01:32:43 +02:00
Refactoring: Corrections and unifications in mathematics vfont gizmos

Hey, that is working way better now.

Although a bit picky, current code shows the text cursor (caret) lining up vertically perfectly with the selection boxes (left), but are out by a bit with…

Harley Acheson commented on pull request blender/blender#106388 2023-04-20 23:49:24 +02:00
UI: replace "x" with multiplication sign when displaying calculations

I should say that this encoding issue recently came up with Campbell on this: #106581 and he didn't want even want Unicode literals in comments. I ended up using the same "Universal Characters…

Harley Acheson commented on pull request blender/blender#104737 2023-04-20 23:42:57 +02:00
Fix #89479: Unable to select hierarchies of multiple objects from outliner

@PratikPB2123 - Sorry for the delay; I didn't notice you made a comment that asked me a question. This new system doesn't seem to notify as much, especially if not specifically at'ed.

Not…

Harley Acheson commented on pull request blender/blender#106724 2023-04-20 23:25:57 +02:00
WIP: UI: Text cursor behavior for Apple Devices

Hey Austin. Thanks for working on this!

With a quick look this seems to be a bit more complex than necessary and probably has some unintended consequences.

Using the first change as an…

Harley Acheson commented on pull request blender/blender#107193 2023-04-20 21:34:27 +02:00
Refactoring: Corrections and unifications in mathematics vfont gizmos

This looks to be a nice start, but needs more testing.

At first glance this appears to nicely improve many issues with the size, placement, and rotation with "Text on Curve".

But try it…

Harley Acheson commented on pull request blender/blender#106915 2023-04-20 18:51:28 +02:00
VFONT: Text Selection Operator

@ideasman42 - This probably wont work with text-on-curve, suggest to avoid all bounding box checks...

Got it! There was a fundamental flaw in Yash's approach of comparing against the mouse…

Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-20 18:38:25 +02:00
98ced9cd79 Unintentional white space change
Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-20 18:36:01 +02:00
10c27713d7 Finding cursor location after transformations. Other review changes.
Harley Acheson commented on pull request blender/blender#106915 2023-04-20 04:46:13 +02:00
VFONT: Text Selection Operator

@ideasman42

Okay I officially give up trying to figure out what Yash was doing there, so dug out all the "squared distance" stuff. The code before the per-character loop is all removed and…