Harley Acheson Harley
  • Joined on 2010-03-07
Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-20 04:40:38 +02:00
8a8724c139 Changes suggested by review
Harley Acheson commented on issue blender/blender#107130 2023-04-20 01:41:15 +02:00
SVG files are not imported with exact values.

To spare any confusion could you please clarify exactly what dimensions you expect and exactly what you get, rather than just say "not exact" or "not accurate" and have us "check the values".…

Harley Acheson pushed to RegisterNew at Harley/blender 2023-04-20 00:40:59 +02:00
2b09300fb9 removing main conflicts.
f87e474af0 Cleanup: Move view3d_gizmo_ruler.c to C++
911f9bea84 Fix #107067: Properly clear CD_FLAG_ACTIVE/DEFAULT_COLOR flags
e05cbad0d1 Sculpt: Fix #107093: expand helper function not specialized to pbvh
2ab500c234 Cleanup: Remove unnecessary point cloud function argument
Compare 145 commits »
Harley Acheson commented on pull request blender/blender#106915 2023-04-20 00:05:30 +02:00
VFONT: Text Selection Operator

@ideasman42 - Naming makes it seem this distance isn't squared, I normally name these *_best & *_test

Did so.

Why is this set to anything at all? besides FLT_MAX or similar

Yes,…

Harley Acheson pushed to TextObjectSelection at Harley/blender 2023-04-19 23:56:57 +02:00
e8280fb455 The rest of the review suggestions
Harley Acheson commented on pull request blender/blender#106871 2023-04-19 23:35:01 +02:00
UI: Import obj files by drag and drop

Just thought about this for a while, I don't know how easy it would be to invoke OP from another OP in C

It's actually pretty easy, but I like your current plan much better anyway.

But…

Harley Acheson commented on pull request blender/blender#106871 2023-04-19 20:55:32 +02:00
UI: Import obj files by drag and drop

Still works like a magic trick.

The new files this adds would also need the same "SPDX-License-Identifier" header you find on other files nearby.

Not sure if better, but worth considering

Harley Acheson deleted branch AssetMetaReadOnly from Harley/blender 2023-04-19 19:55:39 +02:00
Harley Acheson merged pull request blender/blender#105812 2023-04-19 19:55:37 +02:00
Assets: Do Not Show Blank Read-Only Metadata
Harley Acheson pushed to main at blender/blender 2023-04-19 19:55:37 +02:00
199c7da06d Assets: Do Not Show Blank Read-Only Metadata
Harley Acheson deleted branch FileOpsFixes from Harley/blender 2023-04-19 19:43:33 +02:00
Harley Acheson pushed to main at blender/blender 2023-04-19 19:43:30 +02:00
acb34c718e Fix #107120: Small fixes to OS File Operations
Harley Acheson closed issue blender/blender#107120 2023-04-19 19:43:30 +02:00
Issues with OS file operators in file browser
Harley Acheson merged pull request blender/blender#107138 2023-04-19 19:43:28 +02:00
Fix #107120: Small fixes to OS File Operations
Harley Acheson created pull request blender/blender#107138 2023-04-19 19:42:55 +02:00
Fix #107120: Small fixes to OS File Operations
Harley Acheson pushed to FileOpsFixes at Harley/blender 2023-04-19 19:41:55 +02:00
bb1ea025ed Fix #107120: Small fixes to OS File Operations
097b9c5a36 Fix: Build error after last commit
98ccee78fe Geometry Nodes: Slightly optimize mesh to curve node
d5757a0a10 Cycles: re-enable AMD GPU binaries on Windows
45c0762f1b Fix #107125: Entering Grease Pencil Vertex Paint mode crashes
Compare 10 commits »
Harley Acheson created branch FileOpsFixes in Harley/blender 2023-04-19 19:41:55 +02:00
Harley Acheson commented on issue blender/blender#107120 2023-04-19 18:37:59 +02:00
Issues with OS file operators in file browser

@persun - Thank you for this report!

Although it would not be obvious this report is actually for two very different things:

External > Open gets overridden by other operators... Also I…

Harley Acheson commented on pull request blender/blender#106871 2023-04-19 05:03:57 +02:00
UI: Import obj files by drag and drop

Maybe set each WM_dropbox_add on ED_operatortypes_io from the file io_ops.c

Yes, that sounds pretty nice. Haven't thought of any reasons why it wouldn't work well.

Harley Acheson commented on pull request blender/blender#106871 2023-04-19 03:22:47 +02:00
UI: Import obj files by drag and drop

Damn I love this. Please don't take any of the following as me asking you to change anything. Just talking out loud...

Thinking about how this would look with a half-dozen importers done the…