Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke commented on pull request blender/blender#128890 2024-10-16 09:56:19 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Use MEM_new and MEM_delete for LineartModifierRuntime.

Jacques Lucke commented on pull request blender/blender#128890 2024-10-16 09:56:18 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Use a pointer here to avoid making a copy of the Set.

Jacques Lucke commented on pull request blender/blender#128638 2024-10-15 12:44:18 +02:00
Curves: Convert types when transforming

While it's nice to use IndexMask where possible, it does feel like this adds lots of unnecessary complexity here.. It seems like just iterating over the bezier curves and updating them in a…

Jacques Lucke commented on pull request blender/blender#128998 2024-10-15 11:19:23 +02:00
FIX #128997: Wrong evaluation of outputs in the Index of Nearest node

The patch has a formatting issue right now (see the failed lint check). Can you run make format?

https://developer.blender.org/docs/handbook/tooling/clangformat/

Jacques Lucke suggested changes for blender/blender#128890 2024-10-15 11:17:12 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Looks more ok now, got a few smaller comments.

Jacques Lucke commented on pull request blender/blender#128890 2024-10-15 11:17:10 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Better also use a Set here for potentially much better performance in scenes with many objects.

Jacques Lucke commented on pull request blender/blender#128890 2024-10-15 11:17:09 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Think it would be nice to add a GreasePencilLineartModifierRuntime struct to lineart_intern.hh and have it as void *runtime field here.

Jacques Lucke commented on pull request blender/blender#128890 2024-10-15 11:17:08 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Calling contains on a span is inefficient here. Better use a Set instead of a Span so that this check can be O(1).

Jacques Lucke commented on pull request blender/blender#128890 2024-10-15 11:17:07 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Should specify whether the Object pointers are for original or evaluated data-blocks.

Jacques Lucke deleted branch fix-sliced-varray-crash from JacquesLucke/blender 2024-10-15 11:02:46 +02:00
Jacques Lucke closed issue blender/blender#128861 2024-10-15 11:02:43 +02:00
Crash with this particular geometry nodes setup
Jacques Lucke merged pull request blender/blender#128993 2024-10-15 11:02:38 +02:00
Fix #128861: crash with Index Switch node when sliced virtual arrays are used
Jacques Lucke pushed to blender-v4.3-release at blender/blender 2024-10-15 11:02:37 +02:00
5ad56c52ff Fix #128861: crash with Index Switch node when sliced virtual arrays are used
Jacques Lucke commented on pull request blender/blender#129021 2024-10-14 22:06:21 +02:00
Fix: Wrong offset in the 'Has Neighbour' output of the 'Index of Nearest' node

Can you provide a simple test .blend file that shows the bug?

Jacques Lucke pushed to closure-and-bundle at JacquesLucke/blender 2024-10-14 22:02:21 +02:00
1f3fc94735 add todo
e2799e8b56 progress with reference sets
ca1e2f13e5 improve reference set handling
7a2eeff6c2 improve anonymous attribute handling in closures
04db52c264 progress with closure reference set lifetimes
Compare 278 commits »
Jacques Lucke commented on pull request blender/blender#126988 2024-10-14 20:41:34 +02:00
Compositor: Implement Multi-Function Procedure Operation

Right now it's only instantiated for different kinds of inputs. But it's not impossible to also instantiate for different kinds of outputs if that ever becomes necessary.

Jacques Lucke commented on pull request blender/blender#126988 2024-10-14 20:02:26 +02:00
Compositor: Implement Multi-Function Procedure Operation

I think it's perfectly fine to do that right now to avoid all the boilerplate. We could potentially investigate optimizations that avoid the computation of unnecessary outputs if necessary.

Jacques Lucke approved blender/blender#126988 2024-10-14 15:39:27 +02:00
Compositor: Implement Multi-Function Procedure Operation

Looks pretty good and works well in my test with the supported nodes.