Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke commented on pull request blender/blender#126988 2024-10-14 15:39:26 +02:00
Compositor: Implement Multi-Function Procedure Operation

Make sure the include is in all updated node files, unity builds might hide missing includes.

Jacques Lucke commented on pull request blender/blender#126988 2024-10-14 15:39:25 +02:00
Compositor: Implement Multi-Function Procedure Operation

typo (proprieties)

Jacques Lucke commented on pull request blender/blender#128886 2024-10-14 14:48:03 +02:00
Nodes: support subpanels in node group interface

It has not been formally agreed upon yet. I'm just pushing for it a bit. Also a few things have changed since the original implementation. E.g. we can properly support panels in the modifier now.

Jacques Lucke commented on issue blender/blender#128945 2024-10-14 14:27:29 +02:00
Crash on switching from Particle mode to Object mode
ASAN Report
==182792==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f11d9ac5800 at pc 0x000003062d22 bp 0x7ffcff898870 sp 0x7ffcff898868
READ of…
Jacques Lucke deleted branch fix-dot-dash from JacquesLucke/blender 2024-10-14 14:19:47 +02:00
Jacques Lucke closed issue blender/blender#128499 2024-10-14 14:19:44 +02:00
Dot Dash modifier crashes blender on geometry nodes generated grease pencil
Jacques Lucke merged pull request blender/blender#128847 2024-10-14 14:19:39 +02:00
Fix #128499: dot dash modifier crashes because of missing attributes
Jacques Lucke pushed to blender-v4.3-release at blender/blender 2024-10-14 14:19:39 +02:00
2806d54320 Fix #128499: dot dash modifier crashes because of missing attributes
Jacques Lucke commented on issue blender/blender#128938 2024-10-14 14:09:07 +02:00
Crash on duplicate particle system

I can reproduce it. It crashes earlier already in a debug build.

Backtrace
__pthread_kill_implementation@0x00007fffe64ae834 (Unknown Source:0)
raise@0x0000…
Jacques Lucke commented on pull request blender/blender#128890 2024-10-14 14:03:02 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

If not filtering by type, maybe we can modify DEG_OBJECT_ITER_BEGIN into using object_dependencies list as a reference and only return objects that has the original id of those in that list?…

Jacques Lucke suggested changes for blender/blender#128638 2024-10-14 13:55:48 +02:00
Curves: Convert types when transforming

Haven't looked at the code in too much detail yet. It seems the behavior is still different compared to legacy curves.

Jacques Lucke commented on pull request blender/blender#128638 2024-10-14 13:55:46 +02:00
Curves: Convert types when transforming

This is now unused.

Jacques Lucke approved blender/blender#128964 2024-10-14 13:28:19 +02:00
Bake: Speed up "Selected to active" Texture-Baking

Looks good to me beside what is mentioned already.

Jacques Lucke commented on pull request blender/blender#128964 2024-10-14 13:28:18 +02:00
Bake: Speed up "Selected to active" Texture-Baking

Any specific reason for this very large grain size? Multi-threading should be worth it at way lower grain sizes already, especially since the loop body looks fairly costly with a bvh tree lookup.

Jacques Lucke created pull request blender/blender#128993 2024-10-14 13:19:15 +02:00
Fix #128861: crash with Index Switch node when sliced virtual arrays are used
Jacques Lucke pushed to fix-sliced-varray-crash at JacquesLucke/blender 2024-10-14 13:13:03 +02:00
dc45169acd Fix #128637: Gizmo line tool not snapping to exactly 45 degrees
e3f9d210d1 Fix #128401: Issues when splitting connected strip
77b523d317 Fix #128920: Crash calculating geometry nodes that use UV unwrap
72be365c6b Fix #126191: Both handle seqslide modal cancel
Compare 10 commits »
Jacques Lucke created branch fix-sliced-varray-crash in JacquesLucke/blender 2024-10-14 13:13:02 +02:00
Jacques Lucke commented on pull request blender/blender#128890 2024-10-14 12:27:50 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

The less hacky way would be to follow what physics collections are doing: gather all dependencies during DEG construction, and storing them somewhere for a later use. This way evaluation would…

Jacques Lucke commented on pull request blender/blender#128890 2024-10-14 10:19:16 +02:00
Fix #128887: LineArt: Prevent iterating over not evaluated objects

Since those objects can be distinguished by object types.

I don't really think this is possible. Excluding grease pencil objects here is quite wrong, because the evaluated data of grease…