Jacques Lucke JacquesLucke
28 Followers · 0 Following
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Overview Repositories
14
 Projects Public Activity Starred Repositories
1
Jacques Lucke pushed to implicit-sharing at JacquesLucke/blender 2023-03-22 18:14:29 +01:00
34f1b1e06e Merge branch 'implicit-sharing' of projects.blender.org:JacquesLucke/blender into implicit-sharing
ddc0ba8934 improve comments
Compare 2 commits »
Jacques Lucke commented on pull request blender/blender#105994 2023-03-22 18:09:08 +01:00
Core: new blenlib library for implicit-sharing

This looks good to me. I added some comments inline but they're more like questions so I'll accept this now. The naming seems fine to me, though I don't think Implicit is adding much besides…

Jacques Lucke closed issue blender/blender#106002 2023-03-22 17:54:41 +01:00
Regression: Geometry Node: Crash when try to put field value in single Switch node
Jacques Lucke pushed to main at blender/blender 2023-03-22 17:54:39 +01:00
b0045cc797 Fix #106002: crash when passing field into Switch node when it doesn't support it
Jacques Lucke merged pull request blender/blender#106006 2023-03-22 17:54:39 +01:00
Fix #106002: Consider type when choosing switching type
Jacques Lucke approved blender/blender#106006 2023-03-22 17:53:11 +01:00
Fix #106002: Consider type when choosing switching type
Jacques Lucke commented on issue blender/blender#105953 2023-03-22 17:52:44 +01:00
Regression: QuadriFlow Remesh Crash

Can someone confirm that this fixes it?

diff --git a/extern/quadriflow/src/hierarchy.cpp b/extern/quadriflow/src/hierarchy.cpp
index 8cc41da23d0..0bf2ba53b23 100644
--- a/extern/quadriflow/…
Jacques Lucke suggested changes for blender/blender#106006 2023-03-22 17:35:27 +01:00
Fix #106002: Consider type when choosing switching type

Generally makes sense, got one small comment.

Jacques Lucke suggested changes for blender/blender#106006 2023-03-22 17:35:26 +01:00
Fix #106002: Consider type when choosing switching type

Generally makes sense, got one small comment.

Jacques Lucke commented on pull request blender/blender#106006 2023-03-22 17:35:08 +01:00
Fix #106002: Consider type when choosing switching type

Can be simplified to can_be_field_ = ELEM(....)

Jacques Lucke pushed to implicit-sharing at JacquesLucke/blender 2023-03-22 14:14:19 +01:00
5607c08dbd remove const cast
Jacques Lucke pushed to implicit-sharing at JacquesLucke/blender 2023-03-22 14:11:17 +01:00
d1541dec17 improve comment
Jacques Lucke pushed to implicit-sharing at JacquesLucke/blender 2023-03-22 14:09:55 +01:00
6810f4c489 cleanup
Jacques Lucke created pull request blender/blender#105994 2023-03-22 14:08:48 +01:00
Core: new blenlib library for implicit-sharing
Jacques Lucke pushed to implicit-sharing at JacquesLucke/blender 2023-03-22 14:07:24 +01:00
6f965991ca cleanup
d5b14539e3 cleanup
d63aca8865 more renames
ab3fda1c58 initial renames
e2fea7bed6 rename files
Compare 6 commits »
Jacques Lucke created branch implicit-sharing in JacquesLucke/blender 2023-03-22 14:07:24 +01:00
Jacques Lucke approved blender/blender#105990 2023-03-22 12:33:42 +01:00
Fix warning in points to volume node
Jacques Lucke created pull request blender/blender#105986 2023-03-22 11:59:54 +01:00
Timeline: draw cache in overlay so that it stays in sync with actually cached data
Jacques Lucke pushed to redraw-cache-in-timeline at JacquesLucke/blender 2023-03-22 11:57:00 +01:00
1736390cc9 redraw cache in timeline
Jacques Lucke created branch redraw-cache-in-timeline in JacquesLucke/blender 2023-03-22 11:56:59 +01:00