Jacques Lucke JacquesLucke
28 Followers · 0 Following
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Overview Repositories
14
 Projects Public Activity Starred Repositories
1
Jacques Lucke commented on pull request blender/blender#125544 2024-08-29 15:35:34 +02:00
Geometry Nodes: support custom warnings in node groups

Note that #126786 does introduce a distinction between errors and warnings.

Jacques Lucke pushed to main at blender/blender 2024-08-29 13:44:09 +02:00
acda21e055 Cleanup: move inline method definitions out of class
Jacques Lucke pushed to iter-bools-as-bits at JacquesLucke/blender 2024-08-29 12:53:19 +02:00
211015fdd2 initial test
66adedbd78 BLI: optimize constructing IndexMask from bits and bools
491df9df6f Fix #126836: frame node labels are hidden by zones
48208ab2d8 Physics: Show texture properties tab when fluid modifier uses texture
c9f147d301 Fix #126783: Anim: keying will select previously-assigned Slot
Compare 10 commits »
Jacques Lucke created branch iter-bools-as-bits in JacquesLucke/blender 2024-08-29 12:53:19 +02:00
Jacques Lucke deleted branch index-mask-from-bits from JacquesLucke/blender 2024-08-29 12:15:55 +02:00
Jacques Lucke merged pull request blender/blender#126888 2024-08-29 12:15:50 +02:00
BLI: optimize constructing IndexMask from bits and bools
Jacques Lucke pushed to main at blender/blender 2024-08-29 12:15:49 +02:00
66adedbd78 BLI: optimize constructing IndexMask from bits and bools
Jacques Lucke pushed to main at blender/blender 2024-08-29 12:14:20 +02:00
491df9df6f Fix #126836: frame node labels are hidden by zones
Jacques Lucke closed issue blender/blender#126836 2024-08-29 12:14:18 +02:00
Regression: Simulation/repeat zone overlay is opaque for frame titles
Jacques Lucke commented on issue blender/blender#126821 2024-08-29 12:00:20 +02:00
Blender 4.2 - Compress Saving option gets removed when recovering from AutoSave

This shouldn't really be a fundamental limitation of the changes we did to auto-save, it's more like something that was overlooked.

I did notice that there is this line: `const int fileflags =…

Jacques Lucke suggested changes for blender/blender#124369 2024-08-29 11:40:39 +02:00
Geometry Nodes: Importer Cache

Mostly looks good now, just requested some minor changes.

Jacques Lucke commented on pull request blender/blender#124369 2024-08-29 11:40:38 +02:00
Geometry Nodes: Importer Cache

&(&output->reports)->list = &output->reports.list ?

Jacques Lucke commented on pull request blender/blender#124369 2024-08-29 11:40:37 +02:00
Geometry Nodes: Importer Cache

Would be good to make sure that the path is actually absolute. From what I know, it may still be relative here.

Jacques Lucke commented on pull request blender/blender#124369 2024-08-29 11:40:35 +02:00
Geometry Nodes: Importer Cache

this->reports

Jacques Lucke commented on pull request blender/blender#126888 2024-08-29 11:31:39 +02:00
BLI: optimize constructing IndexMask from bits and bools

@blender-bot build

Jacques Lucke pushed to index-mask-from-bits at JacquesLucke/blender 2024-08-29 11:31:21 +02:00
0230c8f3a1 avoid deriving from std type
166af3b5fb cleanup
5afed4800b Merge branch 'main' into index-mask-from-bits
925bed91c7 Fix: mutable parameter should not be const
d497452a73 Cleanup: typo, spaces in comments, comment blocks & use double quotes
Compare 26 commits »
Jacques Lucke commented on pull request blender/blender#126888 2024-08-29 11:25:20 +02:00
BLI: optimize constructing IndexMask from bits and bools

Yeah, I optimized it a bit more to avoid performance regressions in a few cases, but I think there are more potential optimizations. For example, one could always process 64 bools at once: convert…

Jacques Lucke commented on pull request blender/blender#126888 2024-08-29 11:19:41 +02:00
BLI: optimize constructing IndexMask from bits and bools

Yeah, that would be good. Two notes:

  • BitVector is a bit special in that sense, because it initializes the bits always currently, even if no explicit initializer is given. That's necessary to…
Jacques Lucke pushed to main at blender/blender 2024-08-29 11:16:17 +02:00
925bed91c7 Fix: mutable parameter should not be const
Jacques Lucke pushed to index-mask-from-bits at JacquesLucke/blender 2024-08-29 11:13:43 +02:00
2f7d431abb use constexpr
e0847a0422 further improve bool to bit conversion
4368a88f76 improve naming for converting bools to bits
19c1f20ec7 optimize from_bools
Compare 4 commits »