Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke merged pull request blender/blender#126797 2024-08-27 13:47:28 +02:00
Nodes: expose unique identifier for node panels in RNA
Jacques Lucke created pull request blender/blender#126797 2024-08-26 18:52:12 +02:00
Nodes: expose unique identifier for node panels in RNA
Jacques Lucke pushed to expose-readonly-node-panel-uid at JacquesLucke/blender 2024-08-26 18:49:54 +02:00
c062a45b36 expose panel uid
Jacques Lucke created branch expose-readonly-node-panel-uid in JacquesLucke/blender 2024-08-26 18:49:54 +02:00
Jacques Lucke approved blender/blender#126794 2024-08-26 18:04:28 +02:00
Fix #122160: GPv3: Edit mode Undo memory leak.

LGTM, renaming sounds fine to me. The other function should maybe be called CustomData_init_layout_from?

Jacques Lucke commented on pull request blender/blender#122228 2024-08-26 16:22:11 +02:00
Geometry Nodes: Sample Sound node

I also tested the patch with various more pure frequencies (see attached files). That seemed to work well.

One thing I was wondering is how one can interpret the amplitude in a good way. Right…

Jacques Lucke commented on pull request blender/blender#122228 2024-08-26 16:19:07 +02:00
Geometry Nodes: Sample Sound node

Looks like some interpolation is missing here. Maybe that's because low and high are converted to int at some point? image

It would…

Jacques Lucke pushed to gs-function at JacquesLucke/blender 2024-08-26 15:36:28 +02:00
952c25b7b5 use inline keyword, otherwise it seems to be force-inlined even in debug builds
Jacques Lucke pushed to gs-function at JacquesLucke/blender 2024-08-26 15:19:30 +02:00
Jacques Lucke created pull request blender/blender#126787 2024-08-26 15:16:53 +02:00
Cleanup: change GS to be a function instead of a macro
Jacques Lucke created branch gs-function in JacquesLucke/blender 2024-08-26 15:15:33 +02:00
Jacques Lucke pushed to gs-function at JacquesLucke/blender 2024-08-26 15:15:33 +02:00
615691cc57 change GS to be a function instead of a macro
b61e618886 Cleanup: Remove unused function
9c3eb49f8b Cleanup: Compositor: Generalize naming of shader operations
d2c38d3fdc Fix #126535: Missing gamma socket subtype when grouped
dc8f5d5b89 Fix #125333: EEVEE: Trigger render step between rendering of samples
Compare 8 commits »
Jacques Lucke suggested changes for blender/blender#124369 2024-08-26 14:26:34 +02:00
Geometry Nodes: Importer Cache
Jacques Lucke commented on pull request blender/blender#124369 2024-08-26 14:26:33 +02:00
Geometry Nodes: Importer Cache

Was this really necessary? I would have thought that the cache is cleared on exit anyway by static destructors.

Jacques Lucke commented on pull request blender/blender#124369 2024-08-26 14:26:32 +02:00
Geometry Nodes: Importer Cache

The contents of this lambda must not depend on params, it should only depend on the key, which is the file path here.

Jacques Lucke commented on pull request blender/blender#124369 2024-08-26 14:26:31 +02:00
Geometry Nodes: Importer Cache

Looks like this does not have to be in the header.

Jacques Lucke commented on pull request blender/blender#124369 2024-08-26 14:26:30 +02:00
Geometry Nodes: Importer Cache

Would probably make this cache a bit more specific for now. E.g. node_geometry_import_cache.hh.