Jacques Lucke JacquesLucke
28 Followers · 0 Following
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Overview Repositories
14
 Projects Public Activity Starred Repositories
1
Jacques Lucke deleted branch node-tree-self-update from JacquesLucke/blender 2024-08-02 11:43:57 +02:00
Jacques Lucke pushed to main at blender/blender 2024-08-02 11:43:54 +02:00
51f7d37716 Fix: missing update tag when remapping IDs on embedded node trees
Jacques Lucke merged pull request blender/blender#125806 2024-08-02 11:43:54 +02:00
Fix: missing update tag when remapping IDs on embedded node trees
Jacques Lucke suggested changes for blender/blender#125599 2024-08-02 11:42:59 +02:00
GPv3: High level python API
Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:58 +02:00
GPv3: High level python API

Guess this can be removed now that one can just do len(drawing.strokes)? Would be great if there was something similar for points.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:57 +02:00
GPv3: High level python API

make format adds a newline for me here.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:56 +02:00
GPv3: High level python API

By passing in self, you are passing in a GreasePencilStrokeSlice, but you probably intended to pass in the drawing.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:54 +02:00
GPv3: High level python API

Missing dot.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:53 +02:00
GPv3: High level python API

The handling of the step seems quite broken.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:52 +02:00
GPv3: High level python API

validate is an ambiguous term, because it can imply that it corrects the key to be valid. Better use something like _is_valid_index.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:51 +02:00
GPv3: High level python API

Missing dot. Same below multiple times.

Jacques Lucke commented on pull request blender/blender#125599 2024-08-02 11:42:50 +02:00
GPv3: High level python API

You also might not need to implement __iter__. Python can iterate over the sequence even when you just provide __len__ and __getitem__.

Jacques Lucke commented on pull request blender/blender#125806 2024-08-02 11:11:08 +02:00
Fix: missing update tag when remapping IDs on embedded node trees

@blender-bot build

Jacques Lucke created pull request blender/blender#125806 2024-08-02 11:10:50 +02:00
Fix: missing update tag when remapping IDs on embedded node trees
Jacques Lucke pushed to node-tree-self-update at JacquesLucke/blender 2024-08-02 11:09:09 +02:00
589e38ac99 fix
c90f13f2b3 Fix #124702: crash when pasting material
1a266f6894 Cleanup: unused variable
e60422c5a7 GPv3: Delete active keyframe operator
a88327411d Fix: Debug assert for boundary brush
Compare 10 commits »
Jacques Lucke created branch node-tree-self-update in JacquesLucke/blender 2024-08-02 11:09:08 +02:00
Jacques Lucke pushed to main at blender/blender 2024-08-02 11:07:51 +02:00
c90f13f2b3 Fix #124702: crash when pasting material
Jacques Lucke closed issue blender/blender#124702 2024-08-02 11:07:49 +02:00
Blender 4.2 RC - Pasting a material onto itself consistently crashes the program.
Jacques Lucke approved blender/blender#125777 2024-08-02 10:21:53 +02:00
Fix (unreported) wrong alignement handling for mat4x4f DNA struct.
Jacques Lucke pushed to main at blender/blender 2024-08-01 13:37:06 +02:00
6b9b958668 Fix #125291: crash when applying curves modifier when there is a bake