Julian Eisel JulianEisel
  • Amsterdam
  • Asset system (development lead), UI (developer & module coordindator), VR (initial development).

  • Joined on 2013-12-12
Julian Eisel closed pull request blender/blender#105963 2023-03-23 12:25:32 +01:00
UI: Generalize drop target API, support them for UI views
Julian Eisel commented on pull request blender/blender#105963 2023-03-23 12:25:31 +01:00
UI: Generalize drop target API, support them for UI views

Committed as a2d0f7049a.

Julian Eisel pushed to temp-asset-weak-reference at JulianEisel/blender 2023-03-23 12:22:04 +01:00
974ebe4864 Merge branch 'main' into temp-asset-weak-reference
e38ef6aca1 Refactor: Move static functions to the top
Compare 2 commits »
Julian Eisel pushed to temp-asset-weak-reference at JulianEisel/blender 2023-03-23 12:21:28 +01:00
873097b0e6 Address points from review
Julian Eisel pushed to temp-asset-weak-reference at JulianEisel/blender 2023-03-23 12:11:44 +01:00
cb96a82aa6 Fix test failure when test asset path is absolute with ".." components
Julian Eisel pushed to temp-asset-weak-reference at blender/blender 2023-03-23 11:42:54 +01:00
47a1e77a60 Merge branch 'main' into temp-asset-weak-reference
Julian Eisel created branch temp-asset-weak-reference in blender/blender 2023-03-23 11:42:53 +01:00
Julian Eisel pushed to temp-asset-weak-reference at JulianEisel/blender 2023-03-23 11:42:20 +01:00
47a1e77a60 Merge branch 'main' into temp-asset-weak-reference
791f35e2c0 Fix rotation axis not normalized in light tree #OrientationBounds
84e170c563 Animation: Add duration display to frame range settings
b77e6aaa0f Fix warnings in Cycles graph test output
e203e858ec Python: Limit BGL deprecation messages.
Compare 191 commits »
Julian Eisel pushed to main at blender/blender 2023-03-22 18:46:05 +01:00
a2d0f7049a UI: Generalize drop target API, support drop targets for UI views
Julian Eisel pushed to temp-ui-view-drop-controller at JulianEisel/blender 2023-03-22 18:40:25 +01:00
c5bebee18f Merge branch 'main' into temp-ui-view-drop-controller
15c673175d Merge branch 'blender-v3.5-release'
689b0ed1c2 Fix macOS x86_64 clean deps build cmake errors with numpy
b0045cc797 Fix #106002: crash when passing field into Switch node when it doesn't support it
8b2d959344 Cleanup: Remove references to Blender 3.7.
Compare 11 commits »
Julian Eisel pushed to temp-ui-view-drop-controller at JulianEisel/blender 2023-03-22 18:37:23 +01:00
b7c32d844e Improve DropTargetInterface comment some more
Julian Eisel pushed to temp-ui-view-drop-controller at JulianEisel/blender 2023-03-22 17:47:24 +01:00
7d7a7e919b Update DropTargetInterface comment
Julian Eisel commented on issue blender/blender#105250 2023-03-22 17:29:54 +01:00
Define author of bundle essential assets

From what I can tell the assets are ready for the release. License and copyright are set, author is unset (which AFAIK is intentional). @SimonThommes any changes you still want to do? I think we…

Julian Eisel pushed to temp-ui-view-drop-controller at JulianEisel/blender 2023-03-22 17:14:24 +01:00
a3886ebbbc Move new API functions to blender::ui namespace, remove UI_ prefix
Julian Eisel commented on pull request blender/blender#105963 2023-03-22 17:12:14 +01:00
UI: Generalize drop target API, support them for UI views

Still causes some itches to me, but that won't change unless I try hard enough ;/

Julian Eisel commented on pull request blender/blender#105963 2023-03-22 16:23:19 +01:00
UI: Generalize drop target API, support them for UI views

Hmmm, I just can't myself to like non-member API functions that don't start with a prefix like UI_. It just looks like local functions to me, not API functions.

Julian Eisel pushed to temp-ui-view-drop-controller at JulianEisel/blender 2023-03-22 15:57:39 +01:00
232a9a9f10 Rename drop controller -> drop target
1bbfd4d700 Merge branch 'main' into temp-ui-view-drop-controller
a36841af13 Merge branch 'blender-v3.5-release' into main
0e6cc4f86a Build: changes needed to build on FreeBSD
40bd35c9c4 BLI: Add dirty and cached checks to shared cache
Compare 9 commits »
Julian Eisel commented on pull request blender/blender#105963 2023-03-22 15:25:38 +01:00
UI: Generalize drop target API, support them for UI views

Briefly checking the code, I think we can get rid of uiViewHandle and uiViewItemHandle easily now, and call the member functions directly instead of requiring UI_ wrappers.

Julian Eisel commented on pull request blender/blender#105963 2023-03-22 15:15:48 +01:00
UI: Generalize drop target API, support them for UI views

However, with these interfaces, inheritance, etc. I'm a bit afraid that we're heading in the direction of having massive class hierarchies that will end up being overwhelming and hard to…