Julian Eisel JulianEisel
  • Amsterdam
  • Asset system (development lead), UI (developer & module coordindator), VR (initial development).

  • Joined on 2013-12-12
Julian Eisel approved blender/blender#105835 2023-03-20 11:50:15 +01:00
UI: align tab labels towards panels

Nice! Just a minor tweak for the code, looking fine otherwise.

Julian Eisel pushed to main at blender/blender 2023-03-20 11:44:40 +01:00
8f6415418e Cleanup: Refactor UI tree & grid view building API
Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:55 +01:00
Assets: Implement Traits

Can be removed. I'd for traits we just want to ensure a specific trait is set, we never want the name to be changed (like no automatic .001 suffix). So _ensure() is all we need.

Julian Eisel suggested changes for blender/blender#105841 2023-03-17 15:13:55 +01:00
Assets: Implement Traits

I think we can remove most of the editing capabilities. Let's for now only have a list or traits that is managed internally, with no API functions to edit them. I guess we'd want that later to support custom asset types managed by add-ons, but we may want to use different ways to define those (e.g. a bl_asset_traits property for a new asset type definition).

Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:54 +01:00
Assets: Implement Traits

I think we should consistently use the term "asset traits", not just "traits".

Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:54 +01:00
Assets: Implement Traits

Add MAX_NAME comment.

Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:54 +01:00
Assets: Implement Traits

Don't think we need this. I'd like to have a runtime only has of the asset traits in AssetRepresentation. If we ever need the count of traits we can get the size from that.

Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:54 +01:00
Assets: Implement Traits

Can be removed entirely I guess.

Julian Eisel commented on pull request blender/blender#105841 2023-03-17 15:13:54 +01:00
Assets: Implement Traits

Shouldn't be needed since we don't allow changing traits in the UI.

Julian Eisel pushed to brush-assets-project at blender/blender 2023-03-16 18:02:55 +01:00
8c1eb0e79a Merge branch 'temp-asset-weak-reference' into brush-assets-project
84503ebf34 Add functions to resolve a full path to an asset from the weak reference
6390c90791 Merge branch 'main' into temp-asset-weak-reference
d1a9dbe2bb Merge branch 'main' into temp-asset-weak-reference
3e844fb2dc Attempt to fix linker error on GCC
Compare 5 commits »
Julian Eisel pushed to temp-asset-weak-reference at JulianEisel/blender 2023-03-16 18:02:39 +01:00
84503ebf34 Add functions to resolve a full path to an asset from the weak reference
6390c90791 Merge branch 'main' into temp-asset-weak-reference
ee213f3c4d Merge branch 'blender-v3.5-release'
a958ae36e8 Fix #104305: Crash in node editor with large asset libraries
cb20f2cbf9 Fix build error after previous merge
Compare 8 commits »
Julian Eisel deleted branch temp-fix-volatile-asset-handle from JulianEisel/blender 2023-03-16 16:21:13 +01:00
Julian Eisel closed pull request blender/blender#105773 2023-03-16 16:21:02 +01:00
Fix #104305: Crash in node editor with large asset libraries
Julian Eisel commented on pull request blender/blender#105773 2023-03-16 16:21:01 +01:00
Fix #104305: Crash in node editor with large asset libraries

Committed with a958ae36e8.

Julian Eisel pushed to brush-assets-project at blender/blender 2023-03-16 16:19:43 +01:00
f5bfa3cd6b Merge branch 'asset-shelf' into brush-assets-project
90097c8c77 Merge branch 'main' into asset-shelf
ee213f3c4d Merge branch 'blender-v3.5-release'
a958ae36e8 Fix #104305: Crash in node editor with large asset libraries
cb20f2cbf9 Fix build error after previous merge
Compare 159 commits »
Julian Eisel pushed to asset-shelf at blender/blender 2023-03-16 16:10:46 +01:00
90097c8c77 Merge branch 'main' into asset-shelf
ee213f3c4d Merge branch 'blender-v3.5-release'
a958ae36e8 Fix #104305: Crash in node editor with large asset libraries
cb20f2cbf9 Fix build error after previous merge
7317da80fe Merge branch 'blender-v3.5-release' (won't build, see followup)
Compare 158 commits »
Julian Eisel pushed to main at blender/blender 2023-03-16 15:58:53 +01:00
ee213f3c4d Merge branch 'blender-v3.5-release'
a958ae36e8 Fix #104305: Crash in node editor with large asset libraries
Compare 2 commits »
Julian Eisel closed issue blender/blender#104305 2023-03-16 15:58:52 +01:00
Crash when adding nodegroup asset in node editor (when large Asset Libraries are present)
Julian Eisel pushed to blender-v3.5-release at blender/blender 2023-03-16 15:42:25 +01:00
a958ae36e8 Fix #104305: Crash in node editor with large asset libraries
Julian Eisel pushed to temp-fix-volatile-asset-handle at JulianEisel/blender 2023-03-16 15:39:27 +01:00
2228dc1092 Address review comments
b7c34b92bb Merge branch 'blender-v3.5-release' into temp-fix-volatile-asset-handle
55811b2919 Assets: Add function to query data-block library path from asset
eda6694af3 Merge branch 'blender-v3.5-release' into temp-fix-volatile-asset-handle
4fba59c55d Fix #105803: Cycles slow light tree build when previewing shader nodes
Compare 24 commits »