two ways we could go about that
- we could just land the builder changes, wait for the platform devs to do their thing, then land/test the rest of this PR once its in place
- the platform…
This changed in 4.2 as outlined in the release notes:
https://developer.blender.org/docs/release_notes/4.2/core/#portable-installation
Yeah it's a remnant from times we supported both the 32 and 64 bit compilers, it brings no new information to the table these days.
Needs a better commit message, but counting on @Sergey to take care of that while landing.
This is used by dpcpp, which explicitly requested b73e168 in its documentation, you sure this change is correct? if it is, is a dpcpp rebuild required?
Just to be sure, @Alaska you tested this on actual hardware on windows, correct?
Would it be difficult to replace the generic "application" icon with the official Blender logo ?
not possible with just .msi files, if we wrapped it inside some bootstrapper exe perhaps, but…
This will cascade through some of the deps (oiio will definitely need a rebuild, others may as well)) be sure to list the deps that require rebuilds in #125241
that seems to have done the trick,
including the version be nice, but i'll admit, nitpicking at this point
No news, i just prodded the linux maintainer to look at the linux failure, and we'll likely need devops for the windows one, but they are unavailable till atleast the 15th, so it could be a bit
Looks there's something wrong with your test file, it indeed doesn't seem to work, when i resign it my self however using
`signtool sign /FD SHA256 /f lazydodo.pfx /p lolno /d "It's a me,…
i'd probably try if
msiexec /l * blender.log /i blender-4.2.1-windows-x64-test.msi sheds any light on what's going on there