I'll leave that to the UI team, at face value, it is a little strange that a button labelled "close" would open a new blender
Food for thought: given there are no other deps that rely on either abseil or that utf8 lib, we could link protobuf shared (if it supports that), and sidestep the deps issue that way. We ship a…
you seemed to imply config files ship with protobuf, best to force config here, so we don't accidentally fall back to findProtobuf.cmake which i hear has issues tracking the dependencies.
Bit torn about doing a review on something that may not even end up being used but here we go:
Why is CONFIGURE_COMMAND used, rather than just setting CMAKE_ARGS?
Looks like they messed with their python stuff a little bit, i needed these changes for it to build
REMOVE ME LATER: LazyDodo's fix for skipping HIP when HIP compiler not available
I landed a better fix in main, you can remove this commit
one for the docs : it'll work if you set Tools -> Options -> Text Editor -> File Extension -> Extension: glsl, Editor: Microsoft Visual C++ and close/reopen any open glsl tabs.
![image](/attac…
Heh, yeah soo... fun story, it's more of a "what if" since code completion (on these files) doesn't work at all in the VS IDE , so it doesn't even get to the point it would work badly :)
clang will also take -include on forced includes vs explicit includes, i have no horse in the race but i could see some code completion implementations get confused with the pch/forced include…
The same could be done with /FI msvc and -include [gcc](https://gcc.gnu.org/onlinedocs/gcc-13.…
most of the warns are because of type_traits somehow including math.h and fma haivng a different calling convention there, naively sidestepping it inside gpu_glsl_cpp_stubs.hh like this…
target_precompile_headers(${executable} PRIVATE "gpu_glsl_cpp_stubs.hh")
historically we've only used that when there was a significant savings to be had (ie shave minutes off a build) i…
for VS Code you should be able to use the ninja generator on windows, it likely be the preferred generator for such a setup.
For what it's worth, gave it a whirl with the normal VS IDE (Not VS…
I'd like @Harley to sign off on the user facing changes, so added him as reviewer.