Ray molenkamp LazyDodo
  • Joined on 2014-10-02
Ray molenkamp suggested changes for blender/blender#129974 2024-11-07 17:08:37 +01:00
WIP: Windows: Show popup after crash
Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:36 +01:00
WIP: Windows: Show popup after crash

Not convinced this belongs in this file, all other methods are either MAIN_ or sig_ this feels a bit out of place? @ideasman42 do you have any strong feelings about this?

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:34 +01:00
WIP: Windows: Show popup after crash

all other code around here uses sig_

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:33 +01:00
WIP: Windows: Show popup after crash

missing bli_ prefix

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:32 +01:00
WIP: Windows: Show popup after crash

This should probably live elsewhere, seems like a useful function outside of system_win32 if we're keeping it here, why not just call the UrlEscape API?

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:31 +01:00
WIP: Windows: Show popup after crash

best to convert system_win32.c to C++ in a separate commit/PR.

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:30 +01:00
WIP: Windows: Show popup after crash

lower case functions do not go in public headers they are reserved for static local functions.

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:29 +01:00
WIP: Windows: Show popup after crash

BLI_windows_exception_log_start doesn't exist? you likely mean BLI_windows_exception_capture?

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:27 +01:00
WIP: Windows: Show popup after crash

Not a fan of this pattern, it gives the opportunity of use after frees that normally wouldn't happen if you just passed the exception as an argument to the functions that require it. Also having a function called bli_windows_exception_message_get not have an exception as input parameter is really strange.

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:26 +01:00
WIP: Windows: Show popup after crash

This is more of a UI issue, who is this data for?

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:25 +01:00
WIP: Windows: Show popup after crash

BLI_windows_exception_log_start doesn't exist? you likely mean BLI_windows_exception_capture?

Ray molenkamp commented on pull request blender/blender#129974 2024-11-07 17:08:23 +01:00
WIP: Windows: Show popup after crash

lower case bli_ prefix, but not a static function

Ray molenkamp approved blender/blender#128724 2024-11-06 20:59:40 +01:00
GPU: GLSL compilation as C++ for gpu static shaders

I see nothing wrong with the build system changes, everything else is pretty far out of my normal area and i don't feel qualified to review.

Ray molenkamp commented on issue blender/blender#129895 2024-11-06 17:59:40 +01:00
Cycles crash when launched through Steam and using OptiX

Can't really offer any help here, way out of my comfort zone, @ZedDB as the linux platform maintainer is your best bet here, unsure if we have any contacts at valve but @ThomasDinges be the most…

Ray molenkamp pushed to main at blender/blender 2024-11-04 19:45:54 +01:00
8eadc5eb67 Merge remote-tracking branch 'origin/blender-v4.3-release'
3469dea422 Windows_X64: Libs Autopep8 1.6.0-> 2.3.1
1bf2b9a0f7 Fix: EEVEE: VR not working
Compare 3 commits »
Ray molenkamp pushed to main at blender/lib-windows_x64 2024-11-04 19:44:41 +01:00
283d5458d3 Windows_X64: Autopep8 1.6.0-> 2.3.1
Ray molenkamp pushed to blender-v4.3-release at blender/blender 2024-11-04 19:43:56 +01:00
3469dea422 Windows_X64: Libs Autopep8 1.6.0-> 2.3.1
Ray molenkamp pushed to blender-v4.3-release at blender/lib-windows_x64 2024-11-04 19:38:38 +01:00
283d5458d3 Windows_X64: Autopep8 1.6.0-> 2.3.1
Ray molenkamp commented on pull request blender/blender#129751 2024-11-04 17:51:52 +01:00
WIP: Core: support buffers larger than 2GB in .blend files

The code is simplified a bit because Blender does not support 32 bit platforms anymore (#67184).

That's not what #67184 says though, not even close,. As a project we make the distinction…

Ray molenkamp approved blender/blender#129733 2024-11-04 16:11:51 +01:00
Cleanup: Remove unneeded USD cmake check/guard

think the define was mostly there to help with the transition between lib folders that had it vs lib folders that didn't , can be safely removed (now, it was useful in the past)