Not convinced this belongs in this file, all other methods are either MAIN_
or sig_
this feels a bit out of place? @ideasman42 do you have any strong feelings about this?
This should probably live elsewhere, seems like a useful function outside of system_win32
if we're keeping it here, why not just call the UrlEscape
API?
lower case functions do not go in public headers they are reserved for static local functions.
BLI_windows_exception_log_start
doesn't exist? you likely mean BLI_windows_exception_capture
?
Not a fan of this pattern, it gives the opportunity of use after frees that normally wouldn't happen if you just passed the exception as an argument to the functions that require it. Also having a function called bli_windows_exception_message_get
not have an exception as input parameter is really strange.
BLI_windows_exception_log_start
doesn't exist? you likely mean BLI_windows_exception_capture
?
I see nothing wrong with the build system changes, everything else is pretty far out of my normal area and i don't feel qualified to review.
Can't really offer any help here, way out of my comfort zone, @ZedDB as the linux platform maintainer is your best bet here, unsure if we have any contacts at valve but @ThomasDinges be the most…
The code is simplified a bit because Blender does not support 32 bit platforms anymore (#67184).
That's not what #67184 says though, not even close,. As a project we make the distinction…
think the define was mostly there to help with the transition between lib folders that had it vs lib folders that didn't , can be safely removed (now, it was useful in the past)