LukasTonne/blender
0
2
Fork 1
forked from blender/blender
Code Pull Requests Activity

Allow "Instance on Points" node to instance on physics component #2

Merged
Falk David merged 3 commits from filedescriptor/blender:instances-on-physics-bodies into geometry-nodes-rb-component 2024-07-06 14:49:51 +02:00
Conversation 0 Commits 3 Files Changed 6 +27 -2
Falk David commented 2024-07-06 10:11:55 +02:00
Collaborator
Copy Link

This also changes the "Instance on Points" node to take the rotation field implicitly if nothing is connected to the Rotation socket.

This also changes the "Instance on Points" node to take the `rotation` field implicitly if nothing is connected to the `Rotation` socket.
Falk David added 2 commits 2024-07-06 10:12:04 +02:00
Lukas Tönne requested changes 2024-07-06 11:01:44 +02:00
Dismissed
Lukas Tönne left a comment
Owner
Copy Link

Some additions for the new implicit input needed, otherwise looks fine.

Some additions for the new implicit input needed, otherwise looks fine.
source/blender/nodes/intern/node_declaration.cc
@ -870,6 +871,12 @@ void instance_transform(const bNode & /*node*/, void *r_value)
bke::SocketValueVariant(bke::AttributeFieldInput::Create<float4x4>("instance_transform"));
}
void rotation(const bNode & /*node*/, void *r_value)
Lukas Tönne commented 2024-07-06 11:00:52 +02:00
Owner
Copy Link

If you're adding a new implicit field input it should probably also be supported in node groups.

  • GeometryNodeDefaultInputType enum
  • rna_NodeTreeInterfaceSocket_default_input_itemf
  • set_default_input_field in `node_common.cc
If you're adding a new implicit field input it should probably also be supported in node groups. - `GeometryNodeDefaultInputType` enum - `rna_NodeTreeInterfaceSocket_default_input_itemf` - `set_default_input_field` in `node_common.cc
👍 1
filedescriptor marked this conversation as resolved
Falk David added 1 commit 2024-07-06 12:26:28 +02:00
Falk David requested review from Lukas Tönne 2024-07-06 12:26:41 +02:00
Lukas Tönne approved these changes 2024-07-06 13:11:25 +02:00
Falk David merged commit 66f471fd94 into geometry-nodes-rb-component 2024-07-06 14:49:51 +02:00
Falk David deleted branch instances-on-physics-bodies 2024-07-06 14:49:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Lukas Tönne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: LukasTonne/blender#2
No description provided.
Delete Branch "filedescriptor/blender:instances-on-physics-bodies"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?