Pratik Borhade PratikPB2123
23 Followers · 9 Following
  • Kalyan, India
  • Joined on 2020-12-12
Repositories
3
 Projects Public Activity Starred Repositories
1
Pratik Borhade created branch 130084-sculpt-overlay in PratikPB2123/blender 2024-11-11 05:21:00 +01:00
Pratik Borhade commented on issue blender/blender#130084 2024-11-11 05:10:25 +01:00
GP viewport show overlay disable not working in GP sculpt mode

I'll take a look

Pratik Borhade commented on issue blender/blender#130089 2024-11-11 04:38:25 +01:00
GPv3 : Unchecking "Display Cursor" in draw mode show mouse cursor

cc @filedescriptor

Pratik Borhade commented on issue blender/blender#130089 2024-11-11 04:00:44 +01:00
GPv3 : Unchecking "Display Cursor" in draw mode show mouse cursor

In other object's painting mode, default cursor is set for wm->cursor. Should it be invisible in GP case? 🤔

Pratik Borhade commented on issue blender/blender#130089 2024-11-11 03:53:48 +01:00
GPv3 : Unchecking "Display Cursor" in draw mode show mouse cursor

This is not GP specific issue btw :)

Pratik Borhade closed issue blender/blender#130091 2024-11-11 03:36:24 +01:00
Blender stuck on the gray loading screen
Pratik Borhade commented on issue blender/blender#130091 2024-11-11 03:32:33 +01:00
Blender stuck on the gray loading screen

Hi thanks for the report. This has been observed by other people with hp omen laptop, see: #127835

Pratik Borhade pushed to main at PratikPB2123/.profile 2024-11-10 08:29:43 +01:00
dde2e359d0 Weekly report 2024: Nov 04-10
Pratik Borhade deleted branch cleanup-gpv3 from PratikPB2123/blender 2024-11-10 07:48:48 +01:00
Pratik Borhade merged pull request blender/blender#128693 2024-11-10 07:48:44 +01:00
Cleanup: GPv3: Remove unnecessary check
Pratik Borhade pushed to main at blender/blender 2024-11-10 07:48:43 +01:00
079ccd87c5 Cleanup: GPv3: Remove unnecessary check
Pratik Borhade commented on pull request blender/blender#130081 2024-11-10 06:50:25 +01:00
Fix #130076: Make Grease Pencil Select Similar a callable menu

Something like this:

diff --git a/source/blender/editors/grease_pencil/intern/grease_pencil_select.cc b/source/blender/editors/grease_pencil/intern/grease_pencil_select.cc
index be0ed1273d9.…
Pratik Borhade suggested changes for blender/blender#130081 2024-11-10 06:48:34 +01:00
Fix #130076: Make Grease Pencil Select Similar a callable menu

Hi, thanks for the PR. This will work. I think we can instead use WM_menu_invoke as invoke callback for GREASE_PENCIL_OT_select_similar operator.

Pratik Borhade commented on pull request blender/blender#130082 2024-11-10 06:33:08 +01:00
Fix #130034: GPv3: Deleting root layer group leads to crash

Other possible fixes:

  • Add first level groups to layer_group_cache_ in LayerGroup::ensure_nodes_cache()
  • Use current recursion logic, but loop over group.children, call remove_group() if…
Pratik Borhade commented on issue blender/blender#130034 2024-11-10 06:30:57 +01:00
GPv3 - Deleting root layer group leads to crash

Fix !130082

Pratik Borhade created pull request blender/blender#130082 2024-11-10 06:28:25 +01:00
Fix #130034: GPv3: Deleting root layer group leads to crash
Pratik Borhade created branch 130034-gpv3-group-crash in PratikPB2123/blender 2024-11-10 06:25:18 +01:00
Pratik Borhade pushed to 130034-gpv3-group-crash at PratikPB2123/blender 2024-11-10 06:25:18 +01:00
e4d1efc9a2 Fix #130034: GPv3: Deleting root layer group leads to crash
Pratik Borhade commented on issue blender/blender#130034 2024-11-09 11:14:38 +01:00
GPv3 - Deleting root layer group leads to crash

Something like this resolves the crash (also prevents the recursive function call):

diff --git a/source/blender/blenkernel/intern/grease_pencil.cc b/source/blender/blenkernel/intern/grease_pe…
Pratik Borhade commented on issue blender/blender#130034 2024-11-09 10:41:02 +01:00
GPv3 - Deleting root layer group leads to crash

Looks like group->runtime->layer_group_cache_ stores all groups instead nearest (groups at first level).