Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on issue blender/blender#117683 2024-02-01 21:28:24 +01:00
make icons causes changes to icon32_mod_explode.dat & prvicons.png

Just my two cents: I don't mind if this is kept closed for the purposes of this issue tracker, but I do think it would be valuable to have some kind of tracking for issues like this so they don't…

Sean Kim deleted branch 102585-mask-icon from Sean-Kim/blender 2024-02-01 21:06:56 +01:00
Sean Kim commented on issue blender/blender#112371 2024-02-01 04:16:51 +01:00
Sculpting/Painting on invisible objects

Should hopefully have a PR for this issue soon - I've got it working currently for individual objects being hidden, but not the hierarchy toggle.

Sean Kim deleted branch cleanup-automask from Sean-Kim/blender 2024-01-31 22:47:33 +01:00
Sean Kim pushed to 102585-automask-toggle-icon at Sean-Kim/blender 2024-01-31 22:43:05 +01:00
187d522cc7 Merge branch 'main' of projects.blender.org:blender/blender into 102585-automask-toggle-icon
50e1defad6 Remove automasking RNA properties in favor of python code
5fa61ee620 Cleanup: Move remaining spreadsheet editor code to C++ namespace
1934075d97 Fix: Memory leak in gizmo tooltip function
b0063a4690 Cleanup: Perform cleanup on sculpt_automasking.cc
Compare 96 commits »
Sean Kim commented on pull request blender/blender#117467 2024-01-31 21:20:37 +01:00
UI: Update default mask icon

Updated to fix the unintended changes, I had to manually revert the icon32_mod_explode.dat and prvicons.png - still unsure at the moment as to why they change on my laptop when running `make…

Sean Kim pushed to 102585-mask-icon at Sean-Kim/blender 2024-01-31 21:16:06 +01:00
3ae2bc3476 Merge branch 'main' of projects.blender.org:blender/blender into 102585-mask-icon
12839f2c93 Revert changes to icon32_mod_explode.dat and prvicons.png
7b77ba3cde Cleanup: Make format
02895d342c Cleanup: Small changes to asset shelf code
7fa5fc02b7 Cleanup: Move BLF headers to C++
Compare 51 commits »
Sean Kim pushed to cleanup-automask at Sean-Kim/blender 2024-01-31 20:22:02 +01:00
df9490c0b5 Update callers of automask::cache_init
Sean Kim commented on pull request blender/blender#117651 2024-01-31 20:19:06 +01:00
Cleanup: Perform cleanup on sculpt_automasking.cc

Oh, I just realized I didn't change the callers; ignore review request for a bit.

Sean Kim pushed to cleanup-automask at Sean-Kim/blender 2024-01-31 20:16:37 +01:00
062eb1bcc3 Merge branch 'main' of projects.blender.org:blender/blender into cleanup-automask
41c651d872 Address PR comments
7fa5fc02b7 Cleanup: Move BLF headers to C++
e89b4927e4 Cleanup: UI: Remove unused button creation functions
2571bb18be Cleanup: UI: Remove unnecessary function for setting button string
Compare 87 commits »
Sean Kim commented on pull request blender/blender#117651 2024-01-31 19:52:12 +01:00
Cleanup: Perform cleanup on sculpt_automasking.cc

I suppose an alternate option would be to have some form of overload:

std::unique_ptr<Cache> cache_init(const Sculpt *sd, Object *ob);
std::unique_ptr<Cache> cache_init(const Sculpt *sd,…
Sean Kim commented on pull request blender/blender#117651 2024-01-31 19:25:40 +01:00
Cleanup: Perform cleanup on sculpt_automasking.cc

I'll remove the boilerplate parameters - for the non-null pointer to reference, do you just mean changing the callers to be cache_init(s, &brush, ... ) and cache_init(s, nullptr, ...)?

Sean Kim opened issue blender/blender#117683 2024-01-31 02:18:43 +01:00
make icons causes changes to icon32_mod_explode.dat & prvicons.png
Sean Kim deleted branch icons-script from Sean-Kim/blender 2024-01-31 01:35:55 +01:00
Sean Kim created pull request blender/blender#117682 2024-01-31 01:28:47 +01:00
Fix: Adjust alert_icons export-width
Sean Kim created branch icons-script in Sean-Kim/blender 2024-01-31 01:26:27 +01:00
Sean Kim pushed to icons-script at Sean-Kim/blender 2024-01-31 01:26:27 +01:00
8ee465a511 Fix: Adjust alert_icons export-width
6cc80f1213 UI: Panel Chevron Positioning
f87cc8ca8f Addon: catch certain ZIP packaging errors in addon_install
7400b0432c Revert "Fix building with Python 3.12"
Compare 4 commits »
Sean Kim commented on pull request blender/blender#117467 2024-01-31 01:05:59 +01:00
UI: Update default mask icon

I see. So is it just changing which icons are used internally?

There seem to be many (unintended?) changes:

  • release/datafiles/alert_icons.png is wider even
  • explode icon .dat…
Sean Kim deleted branch propagation-steps from Sean-Kim/blender-manual 2024-01-30 23:26:13 +01:00
Sean Kim pushed to 102585-mask-icon at Sean-Kim/blender 2024-01-30 23:04:25 +01:00
e74d4a68bb Merge branch 'main' of projects.blender.org:blender/blender into 102585-mask-icon
f9729a311c Fix building with Python 3.12
8d48770418 UI: Consistent Use of Chevron Disclosure Icons
69d2dd0731 Cleanup: Remove unnecessary keywords in C++ headers
19e2b13cec Cleanup: Move BKE_key.h to C++
Compare 44 commits »