Agreed, left it like this originally to make it match the value in DNA_scene_defaults.h
, but degrees makes more sense as a comment.
According to the comment at the top of the file & dna_defaults.c
this is where the startup.blend
updating happens, not sure why blo_do_versions_400
doesn't apply to it, but when I've done…
Planning on picking work up here soon since the discussion has stalled out, just to be clear there are two main things that need to be done, correct, @JulienKaspar ?
- Update the general…
Note to self to remember to update the docs here after #117316 is merged since it currently specifies that this…
Picking this task up, should have a PR later this week
Sorry that I'm being a bit picky about removing unrelated changes from this PR, but I think it's a good habit to get into, and it makes the life of anyone reading the diff later easier.
No…
Whoops, thought I removed this in the previous commit
Unsure why gitea didnt link the related PR automatically, but it's here: #117316
That seems like it would add more logic onto the python side of things to handle this instead of using the pattern that already exists for the UnifiedPaintSettings
, and I think that having the…
Will do, I was on the fence about adding them, but I decided to keep it in the PR when submitting just to err on the side of more rather than less.
Just to be clear - do you mean the general restructuring that happened in the cache_init
function, or just the added comments?
Oh, makes sense - I got a bit confused with seeing some of the previous changes in this file that do both. I assumed that it was a prerequisite to have both layers of checks.