Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on pull request blender/blender#117433 2024-01-23 04:30:06 +01:00
Sculpt: Add brush settings for view & normal automasking values

Agreed, left it like this originally to make it match the value in DNA_scene_defaults.h, but degrees makes more sense as a comment.

Sean Kim commented on pull request blender/blender#117433 2024-01-23 04:28:27 +01:00
Sculpt: Add brush settings for view & normal automasking values

According to the comment at the top of the file & dna_defaults.c this is where the startup.blend updating happens, not sure why blo_do_versions_400 doesn't apply to it, but when I've done…

Sean Kim commented on issue blender/blender#102585 2024-01-23 03:20:52 +01:00
Improved Mask icon with disabled state

Planning on picking work up here soon since the discussion has stalled out, just to be clear there are two main things that need to be done, correct, @JulienKaspar ?

  1. Update the general…
Sean Kim created pull request blender/blender#117433 2024-01-23 03:10:43 +01:00
Sculpt: Add brush settings for view & normal automasking values
Sean Kim pushed to 115174-automask-limit-falloff at Sean-Kim/blender 2024-01-23 03:02:25 +01:00
ca1dc4b4e8 Sculpt: Add brush settings for view & normal automasking values
b5a9c98e04 Fix #117081: Wrong Roughness when baking Principled BSDF
a4a8683788 UI: Increased Overlay Text Contrast
8dd30838e9 Fix #117423: Broken UI button float display after cleanup
50ff1e843b Cleanup: Remove unnecessary use of mutable linked list iteration
Compare 10 commits »
Sean Kim created branch 115174-automask-limit-falloff in Sean-Kim/blender 2024-01-23 03:02:25 +01:00
Sean Kim commented on issue blender/blender#102377 2024-01-23 02:13:17 +01:00
Auto-Masking: Propagation Steps needed as a global setting

Note to self to remember to update the docs here after #117316 is merged since it currently specifies that this…

Sean Kim commented on issue blender/blender#115174 2024-01-23 00:54:52 +01:00
Auto-Masking Limit and Falloff not a brush setting

Picking this task up, should have a PR later this week

Sean Kim commented on pull request blender/blender#117316 2024-01-20 00:59:26 +01:00
Sculpt: Add global automasking propagation steps

Sorry that I'm being a bit picky about removing unrelated changes from this PR, but I think it's a good habit to get into, and it makes the life of anyone reading the diff later easier.

No…

Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:57:07 +01:00
4aed7e3b00 Remove exists check and unrelated changes
Sean Kim commented on pull request blender/blender#117316 2024-01-20 00:51:19 +01:00
Sculpt: Add global automasking propagation steps

Whoops, thought I removed this in the previous commit

Sean Kim pushed to 108109-unified-input-samples at Sean-Kim/blender 2024-01-20 00:42:37 +01:00
65c312aaa1 Address CR comments
3c888eefc4 Merge branch 'main' of projects.blender.org:blender/blender into 108109-unified-input-samples
33bb3d838f Fix #117224: Outliner recursive selection fails in reverse order
d2e4da0f5b Cleanup: reduce C-isms in imbuf headers
a705259b4b Cleanup: move imbuf .h files to .hh
Compare 139 commits »
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:30:02 +01:00
bc0b22946d Bump subversion correctly
Sean Kim pushed to 102377-auto-masking at Sean-Kim/blender 2024-01-20 00:21:06 +01:00
db184fd490 Address CR comments
346eac756b Merge branch 'main' of projects.blender.org:blender/blender into 102377-auto-masking
33bb3d838f Fix #117224: Outliner recursive selection fails in reverse order
d2e4da0f5b Cleanup: reduce C-isms in imbuf headers
a705259b4b Cleanup: move imbuf .h files to .hh
Compare 62 commits »
Sean Kim commented on issue blender/blender#102377 2024-01-19 21:52:21 +01:00
Auto-Masking: Propagation Steps needed as a global setting

Unsure why gitea didnt link the related PR automatically, but it's here: #117316

Sean Kim commented on pull request blender/blender#117080 2024-01-19 21:50:41 +01:00
Sculpt: Add per-brush input samples

That seems like it would add more logic onto the python side of things to handle this instead of using the pattern that already exists for the UnifiedPaintSettings, and I think that having the…

Sean Kim commented on pull request blender/blender#117080 2024-01-19 21:42:15 +01:00
Sculpt: Add per-brush input samples

Will do, I was on the fence about adding them, but I decided to keep it in the PR when submitting just to err on the side of more rather than less.

Sean Kim commented on pull request blender/blender#117316 2024-01-19 21:39:45 +01:00
Sculpt: Add global automasking propagation steps

Just to be clear - do you mean the general restructuring that happened in the cache_init function, or just the added comments?

Sean Kim commented on pull request blender/blender#117316 2024-01-19 21:37:42 +01:00
Sculpt: Add global automasking propagation steps

Oh, makes sense - I got a bit confused with seeing some of the previous changes in this file that do both. I assumed that it was a prerequisite to have both layers of checks.

Sean Kim created pull request blender/blender#117316 2024-01-19 06:39:35 +01:00
Sculpt: Add global automasking propagation steps