Sergey Sharybin Sergey
  • Joined on 2009-11-28
Sergey Sharybin commented on issue blender/blender#129626 2024-11-19 18:38:58 +01:00
Online Assets: index file format

To me there should be a very strong compelling reason when we're adding a new library, yet alone new technology. The big missing point in the comparison list is the familiarity of other developers…

Sergey Sharybin pushed to main at Sergey/.profile 2024-11-19 12:46:57 +01:00
bc4b8e441f Report for November 11 - 17
Sergey Sharybin commented on pull request blender/blender-test-data#19 2024-11-19 11:47:42 +01:00
Cycles: Add render test for shadow linking on point clouds

should I create a separate PR or add the tests to this one?

I don't have strong opinion. It you think you'd need extra time for curves tests, then landing what you already have I good. And…

Sergey Sharybin pushed to main at infrastructure/blender-devops 2024-11-19 11:22:51 +01:00
0bfed7444b Migrate Buildbot masters to Ubuntu 24.04 on Hetzner
881dd0bb73 Remove CentOS 7 machines and references
db1211dae0 Further tweaks to the memory estimate for GPU step
31bb789004 Further tweak memory estimate
a0bfac4296 Tweak GPU memory estimate
Compare 5 commits »
Sergey Sharybin commented on pull request blender/blender#130407 2024-11-19 10:33:01 +01:00
Creator: Ensure OpenMP runtime is initialized as soon as possible

@mont29 it is not specific to OSX builds, there are areas in Blender that use OpenMP regardless of the platform. Also, external libraries might use OpenMP. So I am not sure how practical it could…

Sergey Sharybin commented on pull request blender/blender#130153 2024-11-18 17:44:54 +01:00
Handling SDK/ROCm 6+ lack of backward compatibility with pre ROCm 6

I am concerned about a situation where hiprt is compiled with one version and a user building blender from source compiles the kernels with a different version of the SDK

I see. Does the…

Sergey Sharybin approved blender/blender#127203 2024-11-18 17:19:44 +01:00
Fix FFmpeg deprecation warnings

Reading the code seems fine! Didn't compile it locally yet though.

Sergey Sharybin approved blender/blender#130444 2024-11-18 16:39:59 +01:00
VSE: Remove byte position index from our time codes

@ZedDB Yep. looks good on the code side. Just ensure the tests are fine, and land it!

Sergey Sharybin commented on issue blender/blender#125255 2024-11-18 16:14:06 +01:00
Crash with some add-ons using OpenMP (conflict initializing)

@jorn Thanks for the PR!

For the macOS I am not sure i fully understand. We ship the same exact libraries versions on Linux and macOS. So there shouldn't be any discrepancy between platforms.

Sergey Sharybin approved blender/blender#130403 2024-11-18 16:08:52 +01:00
VSE: Optimize Text Box w/ roundness with multi-threading

Looks reasonable, but I didn't do accurate line-by-line verification.

Sergey Sharybin commented on pull request blender/blender#130407 2024-11-18 16:05:56 +01:00
Creator: Ensure OpenMP runtime is initialized as soon as possible

I think this approach is better than having a more unpredictable behavior when an addon appears to be working fine, until some operation on Blender side is performed.

Sergey Sharybin commented on pull request blender/blender#130455 2024-11-18 15:59:28 +01:00
Fix #107493, #98480: video rotation metadata is not read

I'd point out somehow nicely "please unrotate" in release notes.

That's probably the least of the messy approaches. I'd also suggest adding this to the commit message.

Have you browsed…

Sergey Sharybin commented on issue blender/blender#130340 2024-11-18 15:53:30 +01:00
NDOF Button 1 not recognized, NDOF Button 2 recognized as NDOF Menu

I can not reproduce the issue with the space mouse (3Dconnexion Space Navigator 3D Mouse) i have available here. Ubuntu 24.04, spacenavd from the repos.

Sergey Sharybin commented on pull request blender/blender#130444 2024-11-18 15:33:33 +01:00
VSE: Remove byte position index from our time codes

The code is almost. The only thing is that seems we can get rid of anim_index_entry::_pad;

Sergey Sharybin commented on pull request blender/blender#130444 2024-11-18 15:33:31 +01:00
VSE: Remove byte position index from our time codes

Seems we never read or write the entire struct, and always do it on the per-field basis? If so, we can remove the _pad from the struct.