Sergey Sharybin Sergey
  • Joined on 2009-11-28
Sergey Sharybin commented on pull request blender/blender#130455 2024-11-18 15:16:32 +01:00
Fix #107493, #98480: video rotation metadata is not read

Great test footage, love it!

The annoying part is that it's not impossible that someone already have some projects with the rotated video, and gave up on Blender's smartness, and rotated the…

Sergey Sharybin pushed to main at Sergey/blender 2024-11-18 12:37:17 +01:00
8467e05036 Fix: Make CMake files compatible with CMake 3.10
cf39bd3704 Merge branch 'blender-v4.3-release'
7911f8e6b3 Fix #130353: GPv3: Fill strokes disappear when using bucket fill
bbbe08d0b0 Fix #111703: banding and color shift when decoding some videos
7dfe47164a Fix #130325: GPv3: Update overlay on changing active layer in dopesheet
Compare 44 commits »
Sergey Sharybin deleted branch fix_cmake from Sergey/blender 2024-11-18 12:32:38 +01:00
Sergey Sharybin pushed to main at blender/blender 2024-11-18 12:32:35 +01:00
8467e05036 Fix: Make CMake files compatible with CMake 3.10
Sergey Sharybin merged pull request blender/blender#130447 2024-11-18 12:32:35 +01:00
Fix: Make CMake files compatible with CMake 3.10
Sergey Sharybin commented on pull request blender/blender#130447 2024-11-18 12:02:21 +01:00
Fix: Make CMake files compatible with CMake 3.10

@blender-bot build linux

Sergey Sharybin created pull request blender/blender#130447 2024-11-18 12:02:01 +01:00
Fix: Make CMake files compatible with CMake 3.10
Sergey Sharybin pushed to fix_cmake at Sergey/blender 2024-11-18 12:01:41 +01:00
82e4aa8740 Fix: Make CMake files compatible with CMake 3.10
704d34fe0f Fix: properly save in-memory and packed textures during USD export
1a96d73f52 Fix: DRW: PassSimple do not pass resource_id correctly
94d2a1e6a2 GPU: GLSL CPP stubs: Allow printf in code
dcec1d5f68 Fix #130365 : Hard to read brush names in Blender Light theme
Compare 10 commits »
Sergey Sharybin created branch fix_cmake in Sergey/blender 2024-11-18 12:01:40 +01:00
Sergey Sharybin commented on pull request blender/blender#130252 2024-11-15 17:14:08 +01:00
WIP: Compositor: Add OIDN Quality to denoise node

@Alaska Here are some thoughts and ideas after discussing things with artists here at the studio (well, mainly Andy):

  • Rename Denoise panel to Denoise Node or something, to make it more…
Sergey Sharybin approved blender/blender#130319 2024-11-15 17:04:03 +01:00
Tests: Add sanity check test for Linux releases

Generally fine. There is some comment about the variable naming/scoping. Not sure it worth extra iteration of review, don't have strong opinion on whether to unset it or move somewhere closer to the beginning of the file.

Sergey Sharybin commented on pull request blender/blender#130319 2024-11-15 17:04:02 +01:00
Tests: Add sanity check test for Linux releases

Maybe use lowercase for RELEASE_ROOT_FOLDER, and unset it before endif()? Or, define it at the top of the?

Sergey Sharybin commented on issue blender/blender#130306 2024-11-15 17:00:15 +01:00
Actions cause audio cliky noises

Blender always keeps an audio handle open. That might have some affect on it. But it also shouldn't really happen. Tricky part is that outside of playback we simply keep handle open. Maybe it's…

Sergey Sharybin commented on pull request blender/blender#130241 2024-11-15 15:40:33 +01:00
Subdiv: Start replacement of "converter" abstraction

Then we can work on a better cache invalidation strategy using implicit sharing.

I am not sure what this refers to. The topology refiner does not share anything with the input, so not sure…

Sergey Sharybin commented on pull request blender/blender#130319 2024-11-15 15:23:54 +01:00
Tests: Add sanity check test for Linux releases

@ZedDB Buildbot uses a dedicated install location. See the set(TEST_INSTALL_DIR .. and set(TEST_BLENDER_EXE. ... in the tests/CMakeLists.txt.

Sergey Sharybin approved blender/blender#130321 2024-11-15 15:16:37 +01:00
Fix: Cycles: Compiler warning

A but annoying, but it is how the code is currently intended to behave. So the silence of the warning is find in this case.

Sergey Sharybin commented on pull request blender/blender#130153 2024-11-15 12:53:28 +01:00
Handling SDK/ROCm 6+ lack of backward compatibility with pre ROCm 6

Meaning doing away with FindHIP.cmake and move the logic to hipew project?

I mean doing something like this: hip.patch

Either, we…