Sergey Sharybin Sergey
14 Followers · 0 Following
  • Joined on 2009-11-28
Repositories
8
 Projects Public Activity Starred Repositories
Sergey Sharybin commented on issue blender/blender#129611 2024-11-15 12:06:52 +01:00
render_init and render_pre handlers on scene data alteration.

Use-after-poiseon is basically the same as use-after-free or use-untinialized-memory.

There seems to be quite high number of reports related on threading and handlers. We'd need to prioritize…

Sergey Sharybin approved blender/blender#130299 2024-11-15 11:56:05 +01:00
Cycles: Reintroduce noinline keyword for oneAPI device

The code side looks fine.

Sergey Sharybin approved blender/blender#130296 2024-11-15 11:42:27 +01:00
Fix: Reading some old blend files fires assert in Sequencer data read

Looks good, tested good!

Sergey Sharybin commented on pull request blender/blender#130296 2024-11-15 10:45:12 +01:00
Fix: Reading some old blend files fires assert in Sequencer data read

@blender-bot build

Sergey Sharybin commented on pull request blender/blender#130252 2024-11-15 10:43:10 +01:00
WIP: Compositor: Add OIDN Quality to denoise node

Thanks for the numbers!

We've been looking into somewhat related aspect of Denoise node configuration for the GPU denoising support.

My feeling is that making UI and controls closer to what…

Sergey Sharybin commented on pull request blender/blender#130296 2024-11-15 10:19:50 +01:00
Fix: Reading some old blend files fires assert in Sequencer data read

Size of a pointer is different on 32 and 64 bit platforms. We don't officially support 32bits, and loading .blend files saved with 32bit Blender is probably already broken. However, to me it feels…

Sergey Sharybin pushed to main at Sergey/blender 2024-11-15 10:06:03 +01:00
38363fb2d7 USD: Add test data for additonal material import/export coverage
091c175c5c Refactor: Move region runtime to separate C++ runtime struct
1e357cdca8 Cleanup: Change calc_*_intersect_data functions to take depth by value
3c32a18fac Cleanup: EEVEE: Remove unused function with legacy API calls
92aa3fe46b Cleanup: Workbench: Address shader warnings
Compare 68 commits »
Sergey Sharybin commented on pull request blender/blender#130296 2024-11-15 10:01:27 +01:00
Fix: Reading some old blend files fires assert in Sequencer data read

That's gonna break 32bit platforms?

Sergey Sharybin commented on pull request blender/blender#130296 2024-11-15 10:01:26 +01:00
Fix: Reading some old blend files fires assert in Sequencer data read

Technically it is deserialization.

Sergey Sharybin deleted branch gpu_metal_context_leak from Sergey/blender 2024-11-14 17:19:20 +01:00
Sergey Sharybin pushed to main at blender/blender 2024-11-14 17:19:17 +01:00
f70ec20ab8 Fix: Leak of GHOST GPU contexts in Metal backend
Sergey Sharybin merged pull request blender/blender#130282 2024-11-14 17:19:16 +01:00
Fix: Leak of GHOST GPU contexts in Metal backend
Sergey Sharybin commented on pull request blender/blender#130282 2024-11-14 16:20:02 +01:00
Fix: Leak of GHOST GPU contexts in Metal backend

@blender-bot build

Sergey Sharybin created pull request blender/blender#130282 2024-11-14 16:19:52 +01:00
Fix: Leak of GHOST GPU contexts in Metal backend
Sergey Sharybin pushed to gpu_metal_context_leak at Sergey/blender 2024-11-14 16:19:33 +01:00
a714a2cf20 Fix: Leak of GHOST GPU contexts in Metal backend
9ad9984611 GPU: Fill uninitialized buffers with poison values
272403a6cb Vulkan: Remove empty attachments
aa8d1a1290 Merge branch 'blender-v4.3-release'
c7432c25ac Tests: increase allowed error threshold for VSE render tests
Compare 10 commits »
Sergey Sharybin created branch gpu_metal_context_leak in Sergey/blender 2024-11-14 16:19:32 +01:00
Sergey Sharybin approved blender/blender#130242 2024-11-14 14:46:16 +01:00
Fix #129414: On linux, Join Use Active Window when Overlapping

Thanks!

Sergey Sharybin commented on pull request blender/blender#130243 2024-11-14 14:44:47 +01:00
Geometry Nodes: Add "Limit Surface" option in subdivision surface node

@HooglyBoogly Yeah ignore them. We are looking into those tests.

Sergey Sharybin approved blender/blender#130243 2024-11-14 14:35:44 +01:00
Geometry Nodes: Add "Limit Surface" option in subdivision surface node
Sergey Sharybin commented on pull request blender/blender#130252 2024-11-14 12:48:02 +01:00
WIP: Compositor: Add OIDN Quality to denoise node

What is the performance and quality difference? Especially in a more realistic setup where compositor is not only doing denoising, but handles other effects?