From 0efa09a67676f0f933b9837eec180ca024c06906 Mon Sep 17 00:00:00 2001 From: Martin Poirier Date: Sun, 13 Dec 2009 22:24:30 +0000 Subject: [PATCH] netrender balancing fix (accessing the list as it is being sorted is not ok) Caused balancing to error when there was only one job (and more generally, to have a slightly wrong result) --- release/scripts/io/netrender/balancing.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release/scripts/io/netrender/balancing.py b/release/scripts/io/netrender/balancing.py index aa0ffcd3f67..410279f6957 100644 --- a/release/scripts/io/netrender/balancing.py +++ b/release/scripts/io/netrender/balancing.py @@ -72,7 +72,8 @@ class Balancer: def balance(self, jobs): if jobs: - jobs.sort(key=self.sortKey) + # use inline copy to make sure the list is still accessible while sorting + jobs[:] = sorted(jobs, key=self.sortKey) return jobs[0] else: return None