From 4bb2a5b5cb700d4564603f882c750eca5544bde6 Mon Sep 17 00:00:00 2001 From: Germano Cavalcante Date: Tue, 18 May 2021 09:39:31 -0300 Subject: [PATCH] Fix T88345: Blender crash on GPUFrameBuffer creation Misuse of indexes. `color_attachements` has only color ones while `config` has color and depth. --- source/blender/python/gpu/gpu_py_framebuffer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/blender/python/gpu/gpu_py_framebuffer.c b/source/blender/python/gpu/gpu_py_framebuffer.c index bc393aaafa4..77eb4a37624 100644 --- a/source/blender/python/gpu/gpu_py_framebuffer.c +++ b/source/blender/python/gpu/gpu_py_framebuffer.c @@ -316,9 +316,9 @@ static PyObject *pygpu_framebuffer__tp_new(PyTypeObject *UNUSED(self), return NULL; } - for (int i = 1; i <= color_attachements_len; i++) { + for (int i = 0; i < color_attachements_len; i++) { PyObject *o = PySequence_GetItem(color_attachements, i); - bool ok = pygpu_framebuffer_new_parse_arg(o, &config[i]); + bool ok = pygpu_framebuffer_new_parse_arg(o, &config[i + 1]); Py_DECREF(o); if (!ok) { return NULL;