From 79ffa03620cdd29b0cd234092ae4ebe2d82a5bec Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Mon, 27 Jul 2015 14:14:17 +0200 Subject: [PATCH] Compositor: Add note that bilateral blur is not really correct The code does stupid box filter which doesn't give nice results and doesn't match old compositor at all. Need some better gaussian weighting here. Will look into it later. --- .../compositor/operations/COM_BilateralBlurOperation.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp index 2527f13c3ed..b24e48f52bc 100644 --- a/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp +++ b/source/blender/compositor/operations/COM_BilateralBlurOperation.cpp @@ -65,6 +65,10 @@ void BilateralBlurOperation::executePixel(float output[4], int x, int y, void *d zero_v4(blurColor); blurDivider = 0.0f; + /* TODO(sergey): This isn't really good bilateral filter, it should be + * using gaussian bell for weights. Also sigma_color doesn't seem to be + * used correct at all. + */ for (int yi = miny; yi < maxy; yi += QualityStepHelper::getStep()) { for (int xi = minx; xi < maxx; xi += QualityStepHelper::getStep()) { // read determinator