From c2e21b23296335bbab6e9acbb59518929efcc8e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Foucault?= Date: Thu, 23 Jan 2020 17:40:40 +0100 Subject: [PATCH] Fix T71374 EEVEE: Fix Node group socket not converting inputs as in Cycles Pretty straight Forward. Create a temp node during sockets expansion to force the conversion to float. --- source/blender/nodes/shader/node_shader_tree.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/source/blender/nodes/shader/node_shader_tree.c b/source/blender/nodes/shader/node_shader_tree.c index dfbc49577e3..612cd0c9293 100644 --- a/source/blender/nodes/shader/node_shader_tree.c +++ b/source/blender/nodes/shader/node_shader_tree.c @@ -332,7 +332,16 @@ static void ntree_shader_groups_expand_inputs(bNodeTree *localtree) bNodeSocket *group_socket = group_node->inputs.first; for (; group_socket; group_socket = group_socket->next) { + if (group_socket->link != NULL) { + bNodeLink *link = group_socket->link; + /* Fix the case where the socket is actually converting the data. (see T71374) + * We only do the case of lossy conversion to float.*/ + if ((group_socket->type == SOCK_FLOAT) && (link->fromsock->type != link->tosock->type)) { + bNode *node = nodeAddStaticNode(NULL, localtree, SH_NODE_RGBTOBW); + nodeAddLink(localtree, link->fromnode, link->fromsock, node, node->inputs.first); + nodeAddLink(localtree, node, node->outputs.first, group_node, group_socket); + } continue; }